FID on OST
(LU-1185)
|
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.4.0 |
| Fix Version/s: | Lustre 2.4.0 |
| Type: | Technical task | Priority: | Major |
| Reporter: | Andreas Dilger | Assignee: | Di Wang |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Rank (Obsolete): | 6269 | ||||||||
| Description |
|
There are a number of cleanups that should be done for the ost_id members of various structures. Access/copying the individual _id and _seq fields should be replaced with the _oi field, and compatibility macros for accessing the individual fields should be removed. POID/DOID macros should be introduced to print out the _oi fields, similar to PFID/DFID is used for lu_fid fields. Johann had a patch for doing some of this in http://review.whamcloud.com/2004 that needs to be refreshed and resubmitted. |
| Comments |
| Comment by Andreas Dilger [ 27/Jan/13 ] |
|
As part of this ost_id cleanup patch, please rename lsm_object_oid to lsm_oi or lsm_ostid, if it hasn't been done through a refresh of http://review.whamcloud.com/3081. It would be good to use a similar field name "_oi" or "_ostid" for other ost_id members in other structures as well. |
| Comment by Andreas Dilger [ 05/Mar/13 ] |
|
Di, I still see a lot of code like: oa->o_id = lsm->lsm_object_id;
oa->o_seq = lsm->lsm_object_seq;
that should be replaced with: oa->o_oi = lsm->lsm_object_oid; also, lsm_object_oid should be renamed lsm_oi or lsm_ostid so that it is not confused with f_oid. |
| Comment by Di Wang [ 05/Mar/13 ] |
| Comment by Peter Jones [ 28/Mar/13 ] |
|
Landed for 2.4 |
[LU-2682]