[LU-2711] Code execution between test declarations in suite scripts

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.12.0
• Type: Bug
• Priority: Minor
• Reporter: Kyr Shatskyy (Inactive)
• Assignee: Bob Glossman (Inactive)
• Resolution: Fixed
• Labels: patch, tests
• Severity: 3

Description

There is present a code execution between test declarations in suite scripts.
For example sanity.sh contains following code:

export ORIG_CSUM_TYPE="`lctl get_param -n osc.*osc-[^mM]*.checksum_type |
                        sed 's/.*\[\(.*\)\].*/\1/g' | head -n1`"
CKSUM_TYPES=${CKSUM_TYPES:-"crc32 adler"}
[ "$ORIG_CSUM_TYPE" = "crc32c" ] && CKSUM_TYPES="$CKSUM_TYPES crc32c"

Or this in sanityn.sh :

}
run_test 39b "mtime change on open, link, unlink, rename  ======"
 
# this should be set to past
TEST_39_MTIME=`date -d "1 year ago" +%s`

# bug 11063
test_39c() {

From one side these codes are executed all the time even if do not want to run it using ONLY parameter for some specific tests. From other side such practice causes generation of unexpected messages in the log files.

This practice is harmfull we need to get rid of it.

Comments

[Andreas Dilger]

http://review.whamcloud.com/5213

[Cliff White (Inactive)]

The patch has failing in testing,is it possible for you to update it?

[Kyr Shatskyy (Inactive)]

New patch 27 uploaded after rebase

[Gerrit Updater]

James Nunez ([e-mail]) uploaded a new patch: https://review.whamcloud.com/30703
Subject: LU-2711 tests: conf-sanity clean up environment in test
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a41f9bee93203b1ad16d02b77a9669776a7718a1

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/30703/
Subject: LU-2711 tests: conf-sanity clean up environment in test
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b79a2cc8f2c72f35e38b93d3399fbf04fe6ad740