[LU-2727] op_bias flag enum is being abused Created: 31/Jan/13 Updated: 09/Jan/20 |
|
| Status: | Open |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Andreas Dilger | Assignee: | WC Triage |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 6629 |
| Description |
|
Looking at http://review.whamcloud.com/4341, it seems that the op_bias flags (e.g. MDS_CROSS_REF in lustre_idl.h) are being abused by various parts of the code. Firstly, the root cause is probably because this enum has no name or comment, so it has become a dumping ground for various flags. Some of them are only local for the MDS, such as MDS_RECOV_OPEN, MDS_KEEP_ORPHAN, MDS_PERM_BYPASS, etc. Some of them (e.g. MDS_SOM, MDS_QUOTA_IGNORE) are not used at all? |
| Comments |
| Comment by Andreas Dilger [ 31/Jan/13 ] |
|
Not a critical bug, but since it relates to network protocol it should probably be fixed by someone who understands what is really supposed to be happening here. |