[LU-273] the patch export-show_task-2.6.18-vanilla.patch of rhel5 has some issues in lustre 2.0.59.0 and above

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.1.0
• Fix Version/s: Lustre 2.1.0
• Type: Bug
• Priority: Minor
• Reporter: Larry Gu
• Assignee: Zhenyu Xu
• Resolution: Fixed

Environment

rhel 5u6, kernel, 2.6.18-164.11.1, lustre 2.0.59.0 and above

• Severity: 3

Description

When building the patched kernel with lustre 2.0.59.0 and above, error happens that "sched_show_task undecleared here". I check the patches in rhel5.series and find that the symbol sched_show_task has been exported in export-show_task-2.6.18-vanilla.patch in sched.c but not defined and decleared in any other place. So I think the symbol name may be wrong and in the wrong place. After changed to EXPORT_SYMBOL(show_task) and put it in line 5055, everything looks ok.

Comments

[Johann Lombardi (Inactive)]

Indeed, i can reproduce the same problem with linux-2.6.18-194.17.1.0.1:

$ grep sched_show_task kernel/sched.c
EXPORT_SYMBOL(sched_show_task);
void sched_show_task(struct task_struct *p)
sched_show_task(p);

It seems that patch is confused.

[Peter Jones]

It looks like Bobijam is working on this

[Zhenyu Xu]

patch tracking at http://review.whamcloud.com/493

[Andreas Dilger]

In newer kernels it is using dump_trace() to Handle this functionality. Is the RHEL5.6 kernel having that function? That woul allow us to drop this patch emtirely.

It is odd that sched_show_task() function in exported, but libcfs/libcfs/linux/linux-debug.c it is still using show_task(). Is that correct? I don't have this kernel to check.

[Larry Gu]

rhel5u6 kernel also has dump_trace(). By the way, I check the patch by Bobijam, find he change the function name, not the symbol name exported. As Andreas said, libcfs/libcfs/linux/linux-debug.c also called show_task(). So I have a question that, which way is useful?

[Zhenyu Xu]

it looks that since 2.6.18 kernel, we always use dump_trace, that explains linux-debug.c calls show_task() while we export sched_show_task() and nothing happened. I think we can drop this kernel patch entirely.

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/series/2.6-rhel5.series
• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/series/2.6-rhel5.series
• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch
• lustre/kernel_patches/series/2.6-rhel5.series

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/series/2.6-rhel5.series
• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/series/2.6-rhel5.series
• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch
• lustre/kernel_patches/series/2.6-rhel5.series

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch
• lustre/kernel_patches/series/2.6-rhel5.series

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/series/2.6-rhel5.series
• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,ofa #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/series/2.6-rhel5.series
• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/series/2.6-rhel5.series
• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/series/2.6-rhel5.series
• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/series/2.6-rhel5.series
• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch
• lustre/kernel_patches/series/2.6-rhel5.series

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #125
LU-273 Remove export-show_task patch

Oleg Drokin : ab251b1bdf8b6c891e60bd78f64c46a506a3daf9
Files :

• lustre/kernel_patches/patches/export-show_task-2.6.18-vanilla.patch
• lustre/kernel_patches/series/2.6-rhel5.series