Tracking bug for static code analysis fixes. (LU-2753)

[LU-2744] Fix 'data race condition' errors Created: 04/Feb/13  Updated: 02/Jun/14  Resolved: 21/Oct/13

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.4.0
Fix Version/s: Lustre 2.5.0, Lustre 2.6.0

Type: Technical task Priority: Minor
Reporter: Sebastien Buisson (Inactive) Assignee: Keith Mannthey (Inactive)
Resolution: Fixed Votes: 0
Labels: build, coverity, patch

Issue Links:
Related
is related to LU-4130 Fix 'data race condition' errors Resolved
Rank (Obsolete): 6668

 Description   

Thanks to the Coverity tool, we found some possible data race conditions in the Lustre code.
I will submit a patch based on the suggestions made by Coverity. It is sometimes quite hard to understand if holding a lock is really necessary, so I want to apologize in advance.

Thanks,
Sebastien.



 Comments   
Comment by Sebastien Buisson (Inactive) [ 04/Feb/13 ]

The patch is at:

http://review.whamcloud.com/5260

TIA,
Sebastien.

Comment by Peter Jones [ 04/Feb/13 ]

Keith

Could you please look into this one?

Thanks

Peter

Comment by Keith Mannthey (Inactive) [ 31/May/13 ]

I did a review of this patch and the locking changes seem odd. In it's current form the patch is not something that should land.

I will invest some more time into the patch.

Comment by Sebastien Buisson (Inactive) [ 06/Jun/13 ]

Hi,

I have split each lock out to make it easier to review.
there are now 9 patchs:
http://review.whamcloud.com/6567
http://review.whamcloud.com/6568
http://review.whamcloud.com/6569
http://review.whamcloud.com/6570
http://review.whamcloud.com/6571
http://review.whamcloud.com/6572
http://review.whamcloud.com/6573
http://review.whamcloud.com/6574
http://review.whamcloud.com/6575

Sebastien.

Comment by Keith Mannthey (Inactive) [ 06/Jun/13 ]

Thanks for splitting the patch up.

Comment by Keith Mannthey (Inactive) [ 12/Jun/13 ]

As you rebase these patches can you rename some of them? 9 patches will all the same name makes it harder to keep track of which one is which.

Comment by Sebastien Buisson (Inactive) [ 02/Oct/13 ]

Hi,

I have made a new patch, involving this time lli_lock:
http://review.whamcloud.com/7825

Can you please also review this one?

Thanks,
Sebastien.

Comment by Jodi Levi (Inactive) [ 21/Oct/13 ]

Patches landed to Master. Follow on work is being tracked in LU-4130.

Generated at Sat Feb 10 01:27:49 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.