[LU-2745] lnet_create_reply_msg

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.6.0, Lustre 2.4.2, Lustre 2.5.1
• Type: Bug
• Priority: Minor
• Reporter: thfeathers
• Assignee: Liang Zhen (Inactive)
• Resolution: Fixed
• Severity: 3

Description

NULL == msg cause lockup

Comments

[Liang Zhen (Inactive)]

Could you provide a little more details? e.g. which version and when it can happen, how the lockup looks like, thanks.

[thfeathers]

i just browsed the source code 2.3.0
function : lnet_create_reply_msg
//------------------------------------------------------------------

cpt = lnet_cpt_of_cookie(getmd->md_lh.lh_cookie);
lnet_res_lock(cpt);//lock res

LASSERT (getmd->md_refcount > 0);

if (msg == NULL) {
CERROR ("%s: Dropping REPLY from %s: can't allocate msg\n",
libcfs_nid2str(ni->ni_nid), libcfs_id2str(peer_id));
//------------------here!goto with hold the res lock
goto drop;
}

if (getmd->md_threshold == 0) {
CERROR ("%s: Dropping REPLY from %s for inactive MD %p\n",
libcfs_nid2str(ni->ni_nid), libcfs_id2str(peer_id),
getmd);
//-------------------here!goto with release the res lock
lnet_res_unlock(cpt);
goto drop;
}

[Liang Zhen (Inactive)]

ah, thanks, I will post a patch.

[Liang Zhen (Inactive)]

patch is here: http://review.whamcloud.com/#change,5542

[Liang Zhen (Inactive)]

patch landed

[Liang Zhen (Inactive)]

hmm, it's not landed, reopen it.

[Peter Jones]

It's landed for 2.6 now