[#LU-279] Test failure on test suite sanity, subtest test

// ... // path is a pointer to a sting with the pathname to a directory // on a lustre filesystem ssize_t ret1 = lgetxattr(path, "lustre.lov", NULL, 0); // returns 96 char *buf = (char *)malloc(ret1); ssize_t ret2 = lgetxattr(path, "lustre.lov", buf, ret1); // returns 56 // Thus at this point ret1 equals 96 and ret2 equals 56 // Shouldn't ret1 and ret2 be the same value?? // ...

Here is what I am seeing on my end using rsync v3.0.6 on a RHEL6 based system ...

# /mnt/lustre > rsync --version | head -1
rsync  version 3.0.6  protocol version 30
# /mnt/lustre > ls -lR
.:
total 0
# /mnt/lustre > mkdir -p ./dir ./dir.new
# /mnt/lustre > touch ./dir/file
# /mnt/lustre > ln -s file ./dir/file.lnk
# /mnt/lustre > ls -lR
.:
total 8
drwx------ 2 root root 4096 May  9 11:35 dir
drwx------ 2 root root 4096 May  9 11:35 dir.new

./dir:
total 0
-rw------- 1 root root 0 May  9 11:35 file
lrwxrwxrwx 1 root root 4 May  9 11:35 file.lnk -> file

./dir.new:
total 0
# /mnt/lustre > strace rsync -av -X ./dir/ ./dir.new/ > strace.txt 2>&1
# /mnt/lustre > ls -lR
.:
total 8
drwx------ 2 root root  4096 May  9 11:35 dir
drwx------ 2 root root  4096 May  9 11:35 dir.new
-rw------- 1 root root 10941 May  9 11:36 strace.txt

./dir:
total 0
-rw------- 1 root root 0 May  9 11:35 file
lrwxrwxrwx 1 root root 4 May  9 11:35 file.lnk -> file

./dir.new:
total 0
# /mnt/lustre > cat strace.txt

# ... Output abbreviated to highlight lgetxattr calls ...

llistxattr(".", 0x6797f0, 1024)         = 36
lgetxattr(".", "trusted.lma", 0x0, 0)   = 64
lgetxattr(".", "trusted.lma", "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x04\x00\x00\x02\x00\x00\x00\x0f\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00", 64) = 64
lgetxattr(".", "trusted.link", 0x0, 0)  = 45
lgetxattr(".", "trusted.link", "\xdf\xf1\xea\x11\x01\x00\x00\x00-\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x15\x00\x00\x00\x00\x00\x00\x00\x13\x03D\x8d\x8d\x00\x00\x00\x00dir", 45) = 45
lgetxattr(".", "lustre.lov", 0x0, 0)    = 96
lgetxattr(".", "lustre.lov", "\xd0\x0b\xd1\x0b\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xff\xff\xff\xff\xff\xff\xff\xff\x00\x00\x10\x00\x01\x00\xff\xff", 96) = 32

# ...

# /mnt/lustre > rsync -av -X ./dir/ ./dir.new/
sending incremental file list
get_xattr_data: lgetxattr(".","lustre.lov",96) returned 32

sent 18 bytes  received 12 bytes  60.00 bytes/sec
total size is 0  speedup is 0.00
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1039) [sender=3.0.6]
# /mnt/lustre > ls -lR
.:
total 20
drwx------ 2 root root 4096 May  9 11:35 dir
drwx------ 2 root root 4096 May  9 11:35 dir.new
-rw------- 1 root root  287 May  9 11:46 strace.txt

./dir:
total 0
-rw------- 1 root root 0 May  9 11:35 file
lrwxrwxrwx 1 root root 4 May  9 11:35 file.lnk -> file

./dir.new:
total 0

Looking at the output from strace, it definitely appears to be calling lgetxattr twice for every xattr.

And from digging into the v3.0.8 rsync source, I believe the relevant code is found in xattrs.c

static char *get_xattr_data(const char *fname, const char *name, size_t *len_ptr,
                            int no_missing_error)
{
        size_t datum_len = sys_lgetxattr(fname, name, NULL, 0);

        // ...

        if (datum_len) {
                size_t len = sys_lgetxattr(fname, name, ptr, datum_len);
                if (len != datum_len) {
                        if (len == (size_t)-1) {
                                // ...
                        } else {
                                rprintf(FERROR_XFER,
                                    "get_xattr_data: lgetxattr(\"%s\",\"%s\",%ld)"
                                    " returned %ld\n", full_fname(fname), name,
                                    (long)datum_len, (long)len);
                        }

                        // ...

[LU-279] Test failure on test suite sanity, subtest test_17k Created: 04/May/11 Updated: 22/Apr/13 Resolved: 14/May/11
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	None
Fix Version/s:	Lustre 2.1.0, Lustre 2.4.0

[LU-279] Test failure on test suite sanity, subtest test_17k Created: 04/May/11 Updated: 22/Apr/13 Resolved: 14/May/11