[LU-2800] build: clean out old autoconf options Created: 13/Feb/13 Updated: 17/Dec/13 Resolved: 02/Dec/13 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.6.0, Lustre 2.4.2 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Jeff Mahoney | Assignee: | Bob Glossman (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | patch | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 6778 | ||||||||
| Description |
|
It currently takes longer to run configure on the Lustre source than it does to build it. There are a ton of configure tests that can be removed in light of the support matrix for 2.4+ |
| Comments |
| Comment by Alex Zhuravlev [ 13/Feb/13 ] |
|
Oleg mentioned that configure can be built with caching support so that many tests can use results of the previous configure runs. |
| Comment by Jeff Mahoney [ 13/Feb/13 ] |
|
There's not a ton of duplication in the testing and it already does some caching. I have a patchset that removes all of the obsolete ones. I'm just cleaning it up to pass the pre-commit checks for Gerrit. |
| Comment by Jeff Mahoney [ 13/Feb/13 ] |
|
(Edited long list of commits) This method makes it much more difficult to review patch series. I'll group all of the ones that only remove code together and refactor. |
| Comment by Prakash Surya (Inactive) [ 13/Feb/13 ] |
|
Improving configure time is much appreciated. Thanks for looking into this, Jeff. |
| Comment by Jeff Mahoney [ 15/Feb/13 ] |
|
Is there any way to get the config.log out of Jenkins? http://review.whamcloud.com/5371 works fine for me locally with both SLES and RHEL but is failing there. |
| Comment by Jeff Mahoney [ 21/Feb/13 ] |
|
http://review.whamcloud.com/5505 contains 53 of the test removal commits in one. Outside of modifying another test when removing a dependency, there is only code removal. |
| Comment by Jeff Mahoney [ 22/Feb/13 ] |
|
Ok, I added some debugging output to 5371 so that it dumps find $LINUX/include $LINUX/fs as well as the config.log, so I can see what's going on. The 64-bit quota stuff wants fs/quota/quotaio_v2.h, but it looks like the build environment only provides actual files other than Makefile and Kconfig under fs/ext3 and fs/ext4. I can see the needed files in my own RHEL6 kernel tree, but not in the Jenkins environment. What creates that? Can it be modified to provide those files as well? http://build.whamcloud.com/job/lustre-reviews/13535/ contains the debugging output for reference. |
| Comment by Peter Jones [ 26/Feb/13 ] |
|
Bob Could you please keep an eye on this one? thanks Peter |
| Comment by Bob Glossman (Inactive) [ 27/Feb/13 ] |
|
Jeff, Am I correct in thinking the myriad of previous autoconf patches are now combined into http://review.whamcloud.com/#change,5546 and http://review.whamcloud.com/#change,5505 making all the earlier ones obsolete? |
| Comment by Jeff Mahoney [ 27/Feb/13 ] |
|
No. I combined all the ones that only removed code. I marked the ones that I merged into 5505 as abandoned already. There are still a bunch more that do either slight or more involved modifications. |
| Comment by Minh Diep [ 04/Mar/13 ] |
|
Hi Jeff, Did you try to compare the time it saved after the clean up? |
| Comment by Alexey Shvetsov [ 01/Apr/13 ] |
|
Is there list of updated patches? |
| Comment by Bob Glossman (Inactive) [ 01/Apr/13 ] |
|
Alexey, Not sure I understand the question. Can you just look at the git history on ldiskfs/kernel_patches or lustre/kernel_patches and find what you want to know? |
| Comment by Jeff Mahoney [ 01/Apr/13 ] |
|
If you mean has it been refreshed, I have a refreshed version I can push. I've been holding off since Chris was talking about "false positives" but he hasn't commented since. |
| Comment by James A Simmons [ 02/Jul/13 ] |
|
Finish the first round of the painful resynchronizing of the patches. All the patch for this ticket we be viewed with http://review.whamcloud.com/#/q/status:open+message:LU-2800,n,z Please be aware all patches are against master so if you attempted to apply them all some patches will collide. Having dependencies between patches delays the landing process and we don't know which patches will be merged first. |
| Comment by Prakash Surya (Inactive) [ 02/Jul/13 ] |
|
Because of the "painful resynchronizing" process, it would be great if these can get some attention from Oleg before they become stale again. I'd hate to see cleanup like this die due to lack of attention. |
| Comment by James A Simmons [ 03/Jul/13 ] |
|
Luckily most of the smaller patches will not collide often with other non |
| Comment by James A Simmons [ 12/Jul/13 ] |
|
The follow matches make the next series to merge. They will not conflict with master as it stands or each other. http://review.whamcloud.com/#/c/5336 |
| Comment by James A Simmons [ 23/Jul/13 ] |
|
The follow patches are the next series to merge. They will not conflict with master or each other. Please review if you haven't already. http://review.whamcloud.com/#/c/5338 |
| Comment by James A Simmons [ 22/Aug/13 ] |
|
New series ready to merge. They will not conflict with master or each other. Please review if you haven't already. http://review.whamcloud.com/#/c/5340 |
| Comment by James A Simmons [ 04/Sep/13 ] |
|
Next series is ready. They will not conflict with current master or each other. http://review.whamcloud.com/#/c/5339 The following patches are dependent on the above and have to be applied in the specific order below. http://review.whamcloud.com/#/c/5370 Besides these only a few more patches will be needed after these land. The reason for not posting those patches is that they conflict with multiple patches above. |
| Comment by James A Simmons [ 17/Sep/13 ] |
|
If you have not done so please review the patches below. All of them are ready to be merged. Thank you. http://review.whamcloud.com/#/c/5339 http://review.whamcloud.com/#/c/5370 |
| Comment by James A Simmons [ 25/Oct/13 ] |
|
The patches ready for inspection are: http://review.whamcloud.com/#/c/5347 http://review.whamcloud.com/#/c/5371 |
| Comment by James A Simmons [ 14/Nov/13 ] |
|
We are down to the last few patches. They are: http://review.whamcloud.com/#/c/5347 http://review.whamcloud.com/#/c/5380 - depends on patch http://review.whamcloud.com/#/c/7135 for |
| Comment by James A Simmons [ 20/Nov/13 ] |
|
Only three patches to go. Please review the following patches. http://review.whamcloud.com/#/c/5347 http://review.whamcloud.com/#/c/5380 - depends on patch http://review.whamcloud.com/#/c/7135 from |
| Comment by James A Simmons [ 02/Dec/13 ] |
|
All patches have been landed to master. This ticket can be closed. |
| Comment by Peter Jones [ 02/Dec/13 ] |
|
Fixed in 2.6 |
| Comment by Jian Yu [ 17/Dec/13 ] |
|
Patch http://review.whamcloud.com/8581 landed on Lustre b2_4 branch for 2.4.2. |