[LU-2819] Inverted logic of EXCEPT_SLOW

• Status: Resolved
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: Kyr Shatskyy (Inactive)
• Assignee: WC Triage
• Resolution: Won't Fix
• Severity: 3

Description

Every man can think that EXCEPT_SLOW is a list of test that should be skipped for "slow" testing. In many test we can see such lines as:

[ "$SLOW" = "no" ] && EXCEPT_SLOW="5"

[ "$SLOW" = "no" ] && EXCEPT_SLOW="12 23 33a"

That in fact means "following test should be run only when SLOW=true".
I suppose EXCEPT_SLOW should be something like SLOW_ONLY.
I understand that EXCEPT_SLOW can be read as "except slow tests",
but this is complicated logic.

What about ridding off EXCEPT_SLOW at all and move slow tests to separate suites, like sanity-slow, sanityn-slow?

Comments

[Andreas Dilger]

I don't think there is a significant benefit from changing this. I'd be fine to have a patch before the EXCEPT_SLOW lines that explain what this means, something like:

# Exclude slow tests that take more than a few minutes to run. Enable them with SLOW=yes.
[ "$SLOW" = "no" ] && EXCEPT_SLOW="24o 24D 27m 64b 68 71 77f 78 115 124b 300o"