[LU-282] Some tests in the framework do not properly mark their beginning and end. For example test_27b in sanity.

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.1.0, Lustre 1.8.6
• Fix Version/s: Lustre 2.10.1, Lustre 2.11.0
• Type: Bug
• Priority: Minor
• Reporter: Chris Gearing (Inactive)
• Assignee: WC Triage
• Resolution: Fixed
• Severity: 3

Description

Problem:
Some tests in the framework do not correctly use run_test at the beginning meaning they are not logged.

For example below test 27b is just calling log at the beginning.

test_27a() {
echo '== stripe sanity =============================================='
mkdir -p $DIR/d27 || error "mkdir failed"
$GETSTRIPE $DIR/d27
$SETSTRIPE $DIR/d27/f0 -c 1 || error "lstripe failed"
$CHECKSTAT -t file $DIR/d27/f0 || error "checkstat failed"
pass
log "== test 27b: write to one stripe file ========================="
cp /etc/hosts $DIR/d27/f0 || error
}
run_test 27a "one stripe file =================================="

These need to be fixed up.

Solution:
To find all the incorrect tests will prove dificult, if they take the format above then a grep can find them, this incorrect logs also cause misshapend names in the autotest logs. Once found they can easily be normalised. Changes made will need to apply to 2.1 and 1.8

Comments

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/27322
Subject: LU-282 tests: remove extra logging from sanity 27
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9e8c9cf3e3b4d25ca708e74e8c65384b9f96eb8d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/27322/
Subject: LU-282 tests: remove extra logging from sanity 27
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f0795a24fd79e2cf2c2dccc1a2b510fabd9ddacf

[Peter Jones]

Landed for 2.11

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/28521
Subject: LU-282 tests: remove extra logging from sanity 27
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: ead1d85133db1cea9b64cfa69f33a1ec924cf7c1

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/28521/
Subject: LU-282 tests: remove extra logging from sanity 27
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 6b317f99a4d26a1477fccc5e1a74e7704bc5745b