[LU-2858] Attempts to delete .lustre/ should fail with EPERM

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.4.0
• Fix Version/s: Lustre 2.4.0
• Type: Bug
• Priority: Blocker
• Reporter: Henri Doreau (Inactive)
• Assignee: Di Wang
• Resolution: Fixed
• Labels: LB, fid
• Severity: 3

Description

On master, rm -rf $FSROOT/.lustre/ succeeds though it should (and used to) return EPERM.

According to git bisect, the regression was introduced by change I7483b0f023e4e3de6597da58d3d9f3e96c0d53b7 (http://review.whamcloud.com/#change,4339)

Comments

[Peter Jones]

Di

Could you please look into this one?

Thanks

Peter

[Henri Doreau (Inactive)]

The problem is that the aforementioned patch I7483b0f023e4e3de6597da58d3d9f3e96c0d53b7
modified mdo_unlink() to make it call the corresponding method of the parent instead
of the one of the child. Therefore, dot_lustre_mdd_unlink (that always return -EPERM)
was never invoked.

In the following patch, that fixes the issue, I've added a check to mdt_reint_unlink()
to make sure that we not trying to unlink .lustre/

See:
http://review.whamcloud.com/#change,5544

[Di Wang]

Yes, I am working on the patch, the dot lustre and obf had a few other problem as well. I will post the fix soon. Thanks.

[Di Wang]

http://review.whamcloud.com/#change,5555

[Peter Jones]

Landed for 2.4