[LU-2875] Remove LASSERT()s on return values from req_capsule_client_get() and similar Created: 26/Feb/13  Updated: 19/Mar/14  Resolved: 19/Mar/14

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.4.0, Lustre 2.5.0
Fix Version/s: Lustre 2.6.0

Type: Task Priority: Major
Reporter: John Hammond Assignee: John Hammond
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-4629 Issues found by static analysis tools Resolved
is related to LU-3765 2.5.0<->2.1.5 interop: sanity test 24... Resolved
Rank (Obsolete): 6949

 Comments   
Comment by John Hammond [ 05/Mar/13 ]

Also ensure that -EPROTO (rather than -EFAULT or other) is returned where req_capsule_client_get() fails.

Comment by John Hammond [ 16/Oct/13 ]

Please see http://review.whamcloud.com/#/c/7961/ for a patch to make name (rr_name and rr_tgt) handling safer in the MDT layer.

Comment by Andreas Dilger [ 26/Nov/13 ]

Would be nice to have a short description of the source of this bug (static code analysis, code inspection, defect hit during testing, etc) to be able to determine the urgency of landing the patch.

Comment by John Hammond [ 27/Nov/13 ]

This issue was opened after a read of the MDT code and some discussion with Oleg. Change 7961 was inspired by LU-3765. AFAIK there are no interop situations that LBUG or Oops on bad name handling but I assume there are some corner cases out there.

Comment by Andreas Dilger [ 18/Mar/14 ]

Does Dmitry's http://review.whamcloud.com/9276 patch address these issues, and can this bug be closed?

Generated at Sat Feb 10 01:28:58 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.