[LU-2906] ldlm_{is,set,clear}_bitname macros should replace bit fiddling code

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.6.0
• Type: Improvement
• Priority: Trivial
• Reporter: Bruce Korb (Inactive)
• Assignee: Keith Mannthey (Inactive)
• Resolution: Fixed

Description

The ldlm_lock flag bits have been augmented with accessor macros.
Using these leads to cleaner, more maintainable code than code
that twiddles the bits directly. e.g.

if (flags == 0 && ((lock->l_flags & LDLM_FL_DESTROYED)== 0)) {

can be replaced with

if (flags == 0 && ! ldlm_is_destroyed(lock)) {

Additionally, a couple dinkleberries from LU-2771:

ldlm/ldlm_lock.c:1736: * be granted (below).^IIn this case, ...

an embedded tab character

ldlm/ldlm_lock.c:2171: /* Yes, second time, [...]
ldlm/ldlm_lock.c:2172: running with no res [...] */

comment formatting.

Comments

[Bruce Korb (Inactive)]

include/lustre_dlm.h:773: * \see

what is to be seen is the doxygen doc for lustre_dlm_flags.h thusly:

include/lustre_dlm.h:773: * \see lustre_dlm_flags.h

And that only works if a \file comment is added to lustre_dlm_flags.h

[Bruce Korb (Inactive)]

http://review.whamcloud.com/7398

I wrote a script last weekend to do 90% of the editing work.
With a few minor tweaks (like reformatting a comment to fit
within 80 columns), it is "pretty much" unchanged from that
operation.

[Peter Jones]

Landed for 2.6