[LU-2926] crash in is_bad_inode() Created: 07/Mar/13  Updated: 15/Mar/13  Resolved: 15/Mar/13

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.4.0
Fix Version/s: Lustre 2.4.0

Type: Bug Priority: Blocker
Reporter: Andriy Skulysh Assignee: James Nunez (Inactive)
Resolution: Fixed Votes: 0
Labels: MB, patch

Severity: 3
Rank (Obsolete): 7027

 Description   

ldiskfs_iget() can return error code not just NULL



 Comments   
Comment by Andriy Skulysh [ 07/Mar/13 ]

PATCH: http://review.whamcloud.com/5631

Comment by Andreas Dilger [ 07/Mar/13 ]

How was this bug hit (what test program/application) and how often? This is always useful information when trying to prioritize bugs.

Comment by Andriy Skulysh [ 11/Mar/13 ]

I don't know how often it happens. Here is a trace:

 
5640.261670] Process mdt_03 (pid: 59002, threadinfo ffff88075d16e000, task ffff8807eb6e3580)
[ 5640.271174] Stack:
[ 5640.273511]  ffff88075d16f8a0 ffffffffa0bd992c ffff880752136c50 ffff880752136bf8
[ 5640.281719] <0> ffff88074550e000 ffffffffa0cc0eef ffff88075d16f910 ffffffffa0bd9ac6
[ 5640.290531] <0> ffff88075d16f920 ffff88075d16f968 ffff88075d16f910 ffffffffa0bd961e
[ 5640.299641] Call Trace:
[ 5640.302490]  [<ffffffffa0bd992c>] ldiskfs_xattr_inode_iget+0x4c/0x140 [ldiskfs]
[ 5640.310844]  [<ffffffffa0bd9ac6>] ldiskfs_xattr_inode_get+0x26/0xf0 [ldiskfs]
[ 5640.318928]  [<ffffffffa0bd961e>] ? ldiskfs_xattr_find_entry+0x3e/0x120 [ldiskfs]
[ 5640.327470]  [<ffffffffa0bda4ea>] ldiskfs_xattr_get+0x18a/0x330 [ldiskfs]
[ 5640.335162]  [<ffffffffa0bdc7ab>] ldiskfs_xattr_trusted_get+0x2b/0x30 [ldiskfs]

In any case it is obvious typo.

Comment by James A Simmons [ 13/Mar/13 ]

Can happen on SLES11 SP2 as well. I have patch for that platform at http://review.whamcloud.com/#change,5709

Comment by Peter Jones [ 15/Mar/13 ]

Landed for 2.4

Generated at Sat Feb 10 01:29:25 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.