[LU-296] File test for $TF_FAIL should be double quoted Created: 08/May/11  Updated: 13/May/11  Resolved: 12/May/11

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 1.8.6

Type: Bug Priority: Trivial
Reporter: Chris Horn Assignee: Zhenyu Xu
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 10251

 Description   

The file test for $TF_FAIL variable should be quoted in acceptance-small.sh and auster.sh. Otherwise, if this variable is not defined, bash will spit out something like
acceptance-small.sh: line 123: [: too many arguments

Bash variables should generally be quoted whenever they are referenced. (see http://tldp.org/LDP/abs/html/quotingvar.html).

 Comments   
Comment by Chris Horn [ 08/May/11 ]

http://review.whamcloud.com/516 b1_8 fix pushed for review.

Comment by Chris Horn [ 09/May/11 ]

Patch updated. http://review.whamcloud.com/516

This ticket can probably be renamed to, "Add missing code from b1_8 port of auster/yaml" or some such.

Comment by Peter Jones [ 11/May/11 ]

Bobijam

Could you please look at this one?

Thanks

Peter

Comment by Build Master (Inactive) [ 12/May/11 ]

Integrated in lustre-b1_8 » x86_64,server,el5,ofa #51
LU-296 Add missing code from auster/yaml port to b1_8

Johann Lombardi : 6f2c9a8ec8d4ef13d3b5b28ba514798587711986
Files :

  • lustre/tests/acceptance-small.sh
  • lustre/tests/test-framework.sh
  • lustre/tests/auster.sh
Comment by Build Master (Inactive) [ 12/May/11 ]

Integrated in lustre-b1_8 » x86_64,client,el5,ofa #51
LU-296 Add missing code from auster/yaml port to b1_8

Johann Lombardi : 6f2c9a8ec8d4ef13d3b5b28ba514798587711986
Files :

  • lustre/tests/acceptance-small.sh
  • lustre/tests/auster.sh
  • lustre/tests/test-framework.sh
Comment by Build Master (Inactive) [ 12/May/11 ]

Integrated in lustre-b1_8 » x86_64,client,el6,inkernel #51
LU-296 Add missing code from auster/yaml port to b1_8

Johann Lombardi : 6f2c9a8ec8d4ef13d3b5b28ba514798587711986
Files :

  • lustre/tests/test-framework.sh
  • lustre/tests/auster.sh
  • lustre/tests/acceptance-small.sh
Comment by Build Master (Inactive) [ 12/May/11 ]

Integrated in lustre-b1_8 » i686,client,el5,inkernel #51
LU-296 Add missing code from auster/yaml port to b1_8

Johann Lombardi : 6f2c9a8ec8d4ef13d3b5b28ba514798587711986
Files :

  • lustre/tests/auster.sh
  • lustre/tests/test-framework.sh
  • lustre/tests/acceptance-small.sh
Comment by Build Master (Inactive) [ 12/May/11 ]

Integrated in lustre-b1_8 » x86_64,client,ubuntu1004,inkernel #51
LU-296 Add missing code from auster/yaml port to b1_8

Johann Lombardi : 6f2c9a8ec8d4ef13d3b5b28ba514798587711986
Files :

  • lustre/tests/auster.sh
  • lustre/tests/acceptance-small.sh
  • lustre/tests/test-framework.sh
Comment by Build Master (Inactive) [ 12/May/11 ]

Integrated in lustre-b1_8 » i686,client,el5,ofa #51
LU-296 Add missing code from auster/yaml port to b1_8

Johann Lombardi : 6f2c9a8ec8d4ef13d3b5b28ba514798587711986
Files :

  • lustre/tests/acceptance-small.sh
  • lustre/tests/test-framework.sh
  • lustre/tests/auster.sh
Comment by Build Master (Inactive) [ 12/May/11 ]

Integrated in lustre-b1_8 » i686,client,el6,inkernel #51
LU-296 Add missing code from auster/yaml port to b1_8

Johann Lombardi : 6f2c9a8ec8d4ef13d3b5b28ba514798587711986
Files :

  • lustre/tests/acceptance-small.sh
  • lustre/tests/test-framework.sh
  • lustre/tests/auster.sh
Comment by Build Master (Inactive) [ 12/May/11 ]

Integrated in lustre-b1_8 » x86_64,client,el5,inkernel #51
LU-296 Add missing code from auster/yaml port to b1_8

Johann Lombardi : 6f2c9a8ec8d4ef13d3b5b28ba514798587711986
Files :

  • lustre/tests/auster.sh
  • lustre/tests/test-framework.sh
  • lustre/tests/acceptance-small.sh
Comment by Build Master (Inactive) [ 12/May/11 ]

Integrated in lustre-b1_8 » x86_64,server,el5,inkernel #51
LU-296 Add missing code from auster/yaml port to b1_8

Johann Lombardi : 6f2c9a8ec8d4ef13d3b5b28ba514798587711986
Files :

  • lustre/tests/auster.sh
  • lustre/tests/acceptance-small.sh
  • lustre/tests/test-framework.sh
Comment by Build Master (Inactive) [ 13/May/11 ]

Integrated in lustre-b1_8 » i686,server,el5,inkernel #51
LU-296 Add missing code from auster/yaml port to b1_8

Johann Lombardi : 6f2c9a8ec8d4ef13d3b5b28ba514798587711986
Files :

  • lustre/tests/test-framework.sh
  • lustre/tests/auster.sh
  • lustre/tests/acceptance-small.sh
Comment by Build Master (Inactive) [ 13/May/11 ]

Integrated in lustre-b1_8 » i686,server,el5,ofa #51
LU-296 Add missing code from auster/yaml port to b1_8

Johann Lombardi : 6f2c9a8ec8d4ef13d3b5b28ba514798587711986
Files :

  • lustre/tests/test-framework.sh
  • lustre/tests/auster.sh
  • lustre/tests/acceptance-small.sh
Generated at Sat Feb 10 01:05:39 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.