[LU-3033] Remove dependency for lu_env structure in lu_cdebug_printer

• Status: Closed
• Project: Lustre
• Affects Version/s: Lustre 2.4.0
• Type: Improvement
• Priority: Minor
• Reporter: Prakash Surya (Inactive)
• Assignee: Mikhail Pershin
• Resolution: Low Priority
• Labels: llnl

Description

I was investigating the possibility of removing the need for an lu_env structure from ll_releasepage (as a result of LU-2622), and the first hurdle seems to be the fact that the debug infrastructure relies on this. In particular, it seems lu_cdebug_printer uses this structure to provide a temporary buffer so consecutive, non-newline terminated, calls to the print functions can be concatenated into a single message.

Thus, unless the debug log infrastructure is reworked, I wont be able to remove the lu_env dependency. Since anything modifying the debug log code is likely to touch a lot of lines, I wanted to get some opinions on whether restructuring this would be advantageous.

Is the debug logging infrastructure something that can/should be reworked to be more straight forward and simpler?

Comments

[Peter Jones]

Mike

Is this something that you can help with?

Thanks

Peter

[Andreas Dilger]

Just to chime in - I've also found this debug code to be problematic, and would prefer that it be simplified in some manner. IIRC, my complaint was about the size of buffer it allocated, but in any case it is messy.

[Mikhail Pershin]

Main problem with that was fixed by LU-3321 patch.