[LU-3149] LUSTRE_VERSION_CODE checks break 2.3.90

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.4.0
• Fix Version/s: Lustre 2.4.0
• Type: Bug
• Priority: Blocker
• Reporter: Andreas Dilger
• Assignee: Mikhail Pershin
• Resolution: Fixed
• Labels: MB
• Severity: 3

Description

When we move to the 2.3.90 release for the first RC tag for 2.4.0, the following check in lustre/obdclass/local_storage.c will fail:

#if LUSTRE_VERSION_CODE >= OBD_OCD_VERSION(2, 3, 90, 0)
#error "fix this before release"
#endif
                /*
                 * there is one technical debt left in Orion:
                 * proper hanlding of named vs no-name objects.
                 * Llog objects have name always as they are placed in O/d/...
                 */

This is adjacent to a line in the LU-2886 patch http://review.whamcloud.com/4682, but is not removed by that patch. Presumably the problem is related to the llog objects, so I'm making this a separate bug. If this is being fixed by LU-2886, then possibly this bug should be closed as a duplicate. In either case, a new patch (dependent on http://review.whamcloud.com/4682) needs to be submitted to delete this check, and hopefully fix whatever needs to be fixed before the release.

Comments

[Andreas Dilger]

Mike, this is a release blocker, because this check breaks the build after 2.3.90. Can you please take a look and submit a patch?

[Mikhail Pershin]

http://review.whamcloud.com/6053

patch separates named and unnamed llogs sequences. That helps to don't add named llogs into O/seq/d hierarchy so they have now only single link.

[Peter Jones]

Landed for 2.4