[LU-3185] Make lustre more autoconf style strict.

• Status: Closed
• Project: Lustre
• Affects Version/s: Lustre 2.4.0
• Fix Version/s: Lustre 2.5.0
• Type: Bug
• Priority: Minor
• Reporter: Alexey Lyashkov
• Assignee: Keith Mannthey (Inactive)
• Resolution: Fixed
• Labels: patch
• Severity: 3

Comments

[Alexey Lyashkov]

running autoconf generation scripts with modern autoconf sutite a have lost a warnings and bugs.

configure.ac:27: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded from...
../../lib/autoconf/general.m4:2590: _AC_COMPILE_IFELSE is expanded from...
../../lib/autoconf/general.m4:2606: AC_COMPILE_IFELSE is expanded from...
/Users/shadow/work/lustre/work/WC-review/mac-os/libcfs/autoconf/lustre-libcfs.m4:878: LIBCFS_CONFIGURE is expanded from...
/Users/shadow/work/lustre/work/WC-review/mac-os/config/lustre-build.m4:582: LB_CONFIGURE is expanded from...

configure.ac:3: warning: AM_INIT_AUTOMAKE: two- and three-arguments forms are deprecated.  For more info, see:
configure.ac:3: http://www.gnu.org/software/automake/manual/automake.html#Modernize-AM_INIT_AUTOMAKE-invocation

lustre/obdclass/autoMakefile.am:8: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')

configure.ac:27: warning: AC_CONFIG_SUBDIRS: you should use literals
../../lib/autoconf/status.m4:1097: AC_CONFIG_SUBDIRS is expanded from...
aclocal.m4:7439: LB_SPL_BUILD is expanded from...
aclocal.m4:7561: LB_PATH_ZFS is expanded from...
aclocal.m4:8363: LB_CONFIGURE is expanded from...
configure.ac:27: the top level

..

patch submitted

remote: New Changes:
remote: http://review.whamcloud.com/6083

[Keith Mannthey (Inactive)]

I just wanted to note this patch is adding cfs_ directives and is working towards support on non Linux Platforms.

[Jodi Levi (Inactive)]

Patches landed to Master.

[Andreas Dilger]

http://review.whamcloud.com/7490 is the patch for just autoconf fixes, Shadow created a second bug with the other changes.