[LU-32] always keep buffer_head reference on root node of iam_container

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.0.0
• Fix Version/s: Lustre 2.2.0, Lustre 2.1.4
• Type: Improvement
• Priority: Minor
• Reporter: Liang Zhen (Inactive)
• Assignee: Liang Zhen (Inactive)
• Resolution: Fixed

Description

IAM in ldiskfs-osd will always consume some slots in bh_lru (see: fs/buffer.c), if we keep buffer_head reference on root node, we can save one slot in bh_lru and could be somehow helpful for overall performance, I did some tests, LRU hits increased 5%-10% while creating files if we always keep this reference.

I'm not expert of this, so please post your comment here if it's totally wrong to do this.

Comments

[Liang Zhen (Inactive)]

I've posted the first version of patch at here:

http://review.whamcloud.com/#change,162

[Liang Zhen (Inactive)]

it's probably unacceptable for IAM directory(LDD_F_IAM_DIR), but should we do this at least for interop mode?

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_iam.h
• lustre/osd-ldiskfs/osd_iam.c
• lustre/osd-ldiskfs/osd_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_handler.c
• lustre/osd-ldiskfs/osd_iam.h
• lustre/osd-ldiskfs/osd_iam.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_iam.h
• lustre/osd-ldiskfs/osd_iam.c
• lustre/osd-ldiskfs/osd_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_iam.h
• lustre/osd-ldiskfs/osd_handler.c
• lustre/osd-ldiskfs/osd_iam.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_iam.h
• lustre/osd-ldiskfs/osd_iam.c
• lustre/osd-ldiskfs/osd_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_handler.c
• lustre/osd-ldiskfs/osd_iam.c
• lustre/osd-ldiskfs/osd_iam.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_iam.h
• lustre/osd-ldiskfs/osd_iam.c
• lustre/osd-ldiskfs/osd_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_iam.c
• lustre/osd-ldiskfs/osd_handler.c
• lustre/osd-ldiskfs/osd_iam.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_handler.c
• lustre/osd-ldiskfs/osd_iam.c
• lustre/osd-ldiskfs/osd_iam.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_iam.h
• lustre/osd-ldiskfs/osd_iam.c
• lustre/osd-ldiskfs/osd_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_iam.c
• lustre/osd-ldiskfs/osd_iam.h
• lustre/osd-ldiskfs/osd_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_iam.h
• lustre/osd-ldiskfs/osd_handler.c
• lustre/osd-ldiskfs/osd_iam.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_iam.h
• lustre/osd-ldiskfs/osd_handler.c
• lustre/osd-ldiskfs/osd_iam.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #402
LU-32 osd: keep root node BH ref of IAM container (Revision 4ad943d14235ce8e8599477b340dbd75c076581e)

Result = SUCCESS
Oleg Drokin : 4ad943d14235ce8e8599477b340dbd75c076581e
Files :

• lustre/osd-ldiskfs/osd_iam.c
• lustre/osd-ldiskfs/osd_handler.c
• lustre/osd-ldiskfs/osd_iam.h

[Liang Zhen (Inactive)]

Patch is on 2.2 and master