[LU-321] Don't assume file system name for some test in the lustre test suite

• Status: Closed
• Project: Lustre
• Fix Version/s: Lustre 2.1.0
• Type: Bug
• Priority: Minor
• Reporter: James A Simmons
• Assignee: Jian Yu
• Resolution: Fixed

Environment

Lustre 2.X and 1.8.X

• Severity: 3

Description

Some of the test in the lustre test suite assume the file system name is lustre
which is not always the case.

Comments

[Andreas Dilger]

Note that some of the tests in conf-sanity.sh hard-code "lustre" as the fsname because they create a new test filesystem using that name, or they use a filesystem image with the fsname already formatted in the image.

[James A Simmons]

My first run at this patch broken conf-sanity. Looking at

http://review.whamcloud.com/#change,253

I alone address this issue in the sanity.sh and ost-pool.sh test.

[Peter Jones]

Yu Jian

I would welcome your input on this issue when your time permits

Thanks

Peter

[Jian Yu]

Note that some of the tests in conf-sanity.sh hard-code "lustre" as the fsname because they create a new test filesystem using that name, or they use a filesystem image with the fsname already formatted in the image.

Yes, they are conf-sanity test 32a and 32b. The $LUSTRE/tests/disk1_8.tar.bz2 contains the mds and ost images which were formatted with fsname "lustre". So, we should not change the "lustre" to "$FSNAME" in those two tests. I just checked that they passed with "FSNAME=testfs" on master branch: https://maloo.whamcloud.com/test_sets/360d9620-b785-11e0-8bdf-52540025f9af

After looking through the test suite, James' patch has covered all of the cases.

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/sanity.sh
• lustre/tests/ost-pools.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/ost-pools.sh
• lustre/tests/sanity.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/sanity.sh
• lustre/tests/ost-pools.sh

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/ost-pools.sh
• lustre/tests/sanity.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/sanity.sh
• lustre/tests/ost-pools.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/sanity.sh
• lustre/tests/ost-pools.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/ost-pools.sh
• lustre/tests/sanity.sh

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/ost-pools.sh
• lustre/tests/sanity.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/ost-pools.sh
• lustre/tests/sanity.sh

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/sanity.sh
• lustre/tests/ost-pools.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/sanity.sh
• lustre/tests/ost-pools.sh

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/ost-pools.sh
• lustre/tests/sanity.sh

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/sanity.sh
• lustre/tests/ost-pools.sh

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #252
LU-321 Don't assume file system name for some test

Oleg Drokin : 98aa568197c9eeb9e0348a08a59d12f2afb5d9b0
Files :

• lustre/tests/ost-pools.sh
• lustre/tests/sanity.sh

[Jian Yu]

Patch has been landed on master branch.
Since b1_8 branch does not have sanity test 33c "test llobdstat and write_bytes", we do not need make a patch for it.