[LU-3232] fsfilt_ldiskfs.ko should be in osd-ldiskfs rpm Created: 25/Apr/13  Updated: 12/Aug/13  Resolved: 12/Aug/13

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.4.1, Lustre 2.5.0

Type: Bug Priority: Minor
Reporter: Christopher Morrone Assignee: Bruno Faccini (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-2158 remove lvfs and fsfilt code Resolved
is related to LU-3407 Lustre lquota module built and instal... Resolved
Severity: 3
Rank (Obsolete): 7897

 Description   

The fsfilt_ldiskfs.ko module is currently part of the lustre-modules rpm. However, it uses ldiskfs functions directly, and therefore should be part of the lustre-osd-ldiskfs rpm instead.

This issue could be made moot by LU-2158, however it is none too clear that it will be completed in time for 2.4.0. If it is not, we should at least fix up the packaging.

 Comments   
Comment by Andreas Dilger [ 26/Apr/13 ]

I'd rather just wait for ldiskfs to be deleted via LU-2158, and I think this would just be a distraction to that effort.

Comment by Bruno Faccini (Inactive) [ 26/Apr/13 ]

May be I can add some conditional statement in what I did for LU-2391, to add fsfilt_ldiskfs.ko in lustre-osd-ldiskfs rpm if it exists ?

Comment by Christopher Morrone [ 29/Apr/13 ]

I'd prefer to avoid a conditional. We'll forget to remove and clean it up when LU-2158 is finished. If LU-2158 is really going to land for 2.4.0, we can hold off adjusting the spec file.

Comment by Christopher Morrone [ 03/May/13 ]

If the LU-2158 doesn't land for 2.4.0, we should land the following patch:

http://review.whamcloud.com/6260

Honestly, I would argue that we should land 6260 now. Then LU-2158 can simply remove the two added spec files lines as part of that landing in the future.

Comment by Christopher Morrone [ 24/May/13 ]

Guys, I really think my patch needs to land for 2.4.0.

Without my patch, the lustre-modules rpm requires lustre-osd-ldiskfs, but there is not rpm dependency on said package. So when anyone installs lustre-modules and lustre-osd-zfs, they get this:

WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_free_blocks
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_journal_start_sb
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol __ldiskfs_journal_stop
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_search_right
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_discard_preallocations
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_calc_credits_for_insert
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_insert_extent
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol __ldiskfs_journal_get_write_access
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_mb_new_blocks
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_search_left
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_bread
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_walk_space
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_map_inode_page
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol __ldiskfs_handle_dirty_metadata
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_free_blocks
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_journal_start_sb
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol __ldiskfs_journal_stop
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_search_right
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_discard_preallocations
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_calc_credits_for_insert
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_insert_extent
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol __ldiskfs_journal_get_write_access
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_mb_new_blocks
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_search_left
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_bread
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_walk_space
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_map_inode_page
WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol __ldiskfs_handle_dirty_metadata

LU-2158 is delayed until 2.5, so this really is a requirement for 2.4.0.

Comment by Bruno Faccini (Inactive) [ 27/May/13 ]

Chris, Sorry to leave it without answer/update but I missed the fact that LU-2158 was delayed ...
Just added me to change's reviewers list and bumped its score.

Comment by Christopher Morrone [ 28/May/13 ]

New patch for b2_4:

http://review.whamcloud.com/6471

Rebased patch on master:

http://review.whamcloud.com/6260

Comment by Peter Jones [ 12/Aug/13 ]

It looks to me that this is landed for 2.4.1 and 2.5

Generated at Sat Feb 10 01:32:06 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.