[LU-327] port bug18896 to master(replay-single test_61d: @@@@@@ FAIL: cannot restart mds on Cray xt3)

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 1.8.6
• Fix Version/s: Lustre 2.1.0
• Type: Bug
• Priority: Minor
• Reporter: Hongchao Zhang
• Assignee: Hongchao Zhang
• Resolution: Fixed
• Severity: 3
• Bugzilla ID: 18,896

Description

for mgc, it doesn't cleanup its obd_import if it setup the import but never connect, should add cleanup code in mgc_precleanup just like mdc_precleanup

/* client import will not have been cleaned. */
cfs_down_write(&obd->u.cli.cl_sem);
if (obd->u.cli.cl_import)

{ struct obd_import *imp; imp = obd->u.cli.cl_import; CERROR("client import never connected\n"); class_destroy_import(imp); obd->u.cli.cl_import = NULL; }

cfs_up_write(&obd->u.cli.cl_sem);

Comments

[Peter Jones]

HongChao

I think that you intended to assign this to yourself. Please assign it back to me if this is not the case

Thanks

Peter

[Hongchao Zhang]

patch in http://review.whamcloud.com/#change,917

[Hongchao Zhang]

currently, it's blocked by LU-387(http://jira.whamcloud.com/browse/LU-387)

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/mgc/mgc_request.c
• lustre/mdc/mdc_request.c
• lustre/include/obd_class.h
• lustre/mgc/libmgc.c
• lustre/osc/osc_request.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/mgc/libmgc.c
• lustre/mdc/mdc_request.c
• lustre/include/obd_class.h
• lustre/mgc/mgc_request.c
• lustre/osc/osc_request.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/osc/osc_request.c
• lustre/mgc/libmgc.c
• lustre/mdc/mdc_request.c
• lustre/include/obd_class.h
• lustre/mgc/mgc_request.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/mgc/libmgc.c
• lustre/include/obd_class.h
• lustre/osc/osc_request.c
• lustre/mgc/mgc_request.c
• lustre/mdc/mdc_request.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/osc/osc_request.c
• lustre/mgc/libmgc.c
• lustre/mdc/mdc_request.c
• lustre/mgc/mgc_request.c
• lustre/include/obd_class.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/mgc/libmgc.c
• lustre/mgc/mgc_request.c
• lustre/include/obd_class.h
• lustre/osc/osc_request.c
• lustre/mdc/mdc_request.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/mgc/mgc_request.c
• lustre/osc/osc_request.c
• lustre/include/obd_class.h
• lustre/mdc/mdc_request.c
• lustre/mgc/libmgc.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/mgc/libmgc.c
• lustre/osc/osc_request.c
• lustre/mdc/mdc_request.c
• lustre/mgc/mgc_request.c
• lustre/include/obd_class.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/mgc/mgc_request.c
• lustre/include/obd_class.h
• lustre/mdc/mdc_request.c
• lustre/osc/osc_request.c
• lustre/mgc/libmgc.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/mgc/libmgc.c
• lustre/mdc/mdc_request.c
• lustre/include/obd_class.h
• lustre/mgc/mgc_request.c
• lustre/osc/osc_request.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/include/obd_class.h
• lustre/mdc/mdc_request.c
• lustre/mgc/libmgc.c
• lustre/osc/osc_request.c
• lustre/mgc/mgc_request.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/include/obd_class.h
• lustre/osc/osc_request.c
• lustre/mgc/libmgc.c
• lustre/mdc/mdc_request.c
• lustre/mgc/mgc_request.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/osc/osc_request.c
• lustre/include/obd_class.h
• lustre/mdc/mdc_request.c
• lustre/mgc/mgc_request.c
• lustre/mgc/libmgc.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #239
LU-327 cleanup the client import of mgc

Oleg Drokin : 421d8e98f309870475aadc05aa81a60e9acd8e65
Files :

• lustre/mdc/mdc_request.c
• lustre/include/obd_class.h
• lustre/mgc/mgc_request.c
• lustre/osc/osc_request.c
• lustre/mgc/libmgc.c