[LU-329] ost_lock_get() is not put in some cases

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.1.0
• Fix Version/s: Lustre 2.1.0
• Type: Bug
• Priority: Minor
• Reporter: Mikhail Pershin
• Assignee: Lai Siyao
• Resolution: Fixed
• Severity: 3

Description

While adapting LU-234 to our branch I've found that ost_lock_put() is not called in some error cases. LU-234 added even more such cases. Please check patch attached. I have the question there - do we need to report repbody in case of error in ost_punch()? I doubt that but it is always returned there no matter is 'rc' zero or not.

Comments

[Lai Siyao]

I see repbody filled in most ost_xxx() operations, actually it looks to be a waste in case of error, but it's not a problem, and no need to get fixed here IMO.

[Peter Jones]

Mike

Are you ok to close this ticket in light of Lai's response?

thanks

Peter

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,ofa #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #167
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #170
LU-329 fix missing ost_lock_put() calls

Oleg Drokin : c0468e08ce5864884265a542606f6253cce19bad
Files :

• lustre/ost/ost_handler.c