[LU-336] Function module_loaded in test-framework.sh returns false positives

• Status: Closed
• Project: Lustre
• Affects Version/s: Lustre 2.1.0
• Fix Version/s: Lustre 2.1.0
• Type: Bug
• Priority: Minor
• Reporter: Prakash Surya (Inactive)
• Assignee: Jian Yu
• Resolution: Fixed

Environment

RHEL6 based

• Severity: 3

Description

The function module_loaded can easily produce false positives based on it's lenient way of grep'ing the output of lsmod.

Tightening up the regex can improve upon this.

For example, if checking to see if the 'ost' module is loaded.. It will report true if another module is already loaded and has 'ost' anywhere in its name (i.e. vhost_net).

Function's match criteria could mort strict to avoid this kind of problem:

module_loaded() {
        lsmod | grep ^$1 # Or perhaps even '^\b$1\b'
}

I will submit a patch to gerrit soon.

Comments

[Prakash Surya (Inactive)]

Patch submitted: http://review.whamcloud.com/#change,558

[Peter Jones]

Yu Jian

I think that you might be a more appropriate second inspector than Brian Murrell for this patch

Regards

Peter

[Prakash Surya (Inactive)]

Patch has been merged. Issue resolved.

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,ofa #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #150
LU-336 Tighten matching criteria in module_loaded

Oleg Drokin : ca227f930e41c7598c6cf5b563d65fb6605e306f
Files :

• lustre/tests/test-framework.sh

[Jian Yu]

Patch has been merged. Issue resolved.