[LU-3427] Fix 'error handling' issues

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.4.0
• Fix Version/s: Lustre 2.4.1, Lustre 2.5.0
• Type: Technical task
• Priority: Minor
• Reporter: Sebastien Buisson (Inactive)
• Assignee: Bobbie Lind (Inactive)
• Resolution: Fixed
• Labels: build, coverity, patch

Description

Following LU-2444, Coverity found a few more error handling issues in the Lustre code.

I will propose a patch to address the issues.

Comments

[Sebastien Buisson (Inactive)]

The patch is at:
http://review.whamcloud.com/6510

Thanks,
Sebastien.

[Peter Jones]

Thanks Sebastien

Bobbie

Could you please take care of this patch?

Thanks

Peter

[Bobbie Lind (Inactive)]

The patch was hitting an LBUG found in LU-3453. This bug has been fixed and I rebased and uploaded the rebased patch.

[Bobbie Lind (Inactive)]

This patch broke the compilation of master and was reverted. After speaking with Oleg, the variable that this patch references no longer exists. If you feel the patch is still needed please submit it again.

[Bobbie Lind (Inactive)]

Variable no longer in code base.

[Sebastien Buisson (Inactive)]

Of course I feel this patch is still needed.
The point of the patch was to test the return value of cfs_cpt_bind() in cfs_wi_scheduler(). The fact that a local variable was removed from this function does not change this.
I rewrote the patch replacing the use of this 'name' local variable with sched->ws_name.

Here is the new patch:
http://review.whamcloud.com/7103

Please reopen this ticket.

Thanks,
Sebastien.

[Bobbie Lind (Inactive)]

Reopened per customer request.

[Bobbie Lind (Inactive)]

Patch has landed to master.