[LU-3470] incompatbile error handling in llog_open() Created: 14/Jun/13  Updated: 13/Sep/13  Resolved: 07/Aug/13

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 1.8.9, Lustre 2.4.1, Lustre 2.5.0
Fix Version/s: Lustre 2.4.1, Lustre 2.5.0

Type: Bug Priority: Major
Reporter: Li Xi (Inactive) Assignee: Bobbie Lind (Inactive)
Resolution: Fixed Votes: 0
Labels: mn8, patch

Severity: 3
Rank (Obsolete): 8698

 Description   

In master version, llog_open() calls llog_alloc_handle() bug does not handle return value correctly. It takes NULL as the error return value. But llog_alloc_handle() returns ERR_PTR(-ENOMEM) instead when error.

This is also an problem in llog_client_create() in Lustre-1.8.9. This problem is related to LU-980.



 Comments   
Comment by Li Xi (Inactive) [ 14/Jun/13 ]

the patch is tracked at http://review.whamcloud.com/#change,6644

Comment by Peter Jones [ 14/Jun/13 ]

Thanks Li Xi.

Bobbie

Could you please take care of this patch?

Thanks

Peter

Comment by Bobbie Lind (Inactive) [ 19/Jun/13 ]

This patch failed due to the recently fixed LU-3453 LBUG. I will rebase and resubmit.

Comment by Bobbie Lind (Inactive) [ 24/Jul/13 ]

The patch was successfully cherry-picked to master. I have ported the patch to b1_8 and it is tracked at http://review.whamcloud.com/#/c/7106/

Comment by Bobbie Lind (Inactive) [ 07/Aug/13 ]

Patch has landed to master.

Generated at Sat Feb 10 01:34:11 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.