[LU-3498] most uses of IS_ERR_VALUE() are incorrect Created: 24/Jun/13  Updated: 27/Jun/14  Resolved: 22/Apr/14

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.5.0
Fix Version/s: Lustre 2.6.0, Lustre 2.5.2

Type: Bug Priority: Critical
Reporter: John Hammond Assignee: John Hammond
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Duplicate
Related
is related to LU-5071 statahead.c:1704:do_statahead_enter()... Resolved
Severity: 3
Rank (Obsolete): 8795

 Description   

We have several places in the code that do something equivalent the following

int rc = PTR_ERR(foo);
if (IS_ERR_VALUE(rc))
        bar();

which is wrong.

 Comments   
Comment by John Hammond [ 24/Jun/13 ]

Please see http://review.whamcloud.com/6759.

Comment by Andreas Dilger [ 22/Apr/14 ]

Patch landed to master for 2.6.0.

Comment by Cory Spitz [ 30/Apr/14 ]

As John points out in LU-4985, it would be good to port http://review.whamcloud.com/#/c/6759/ to b2_5.

Comment by Ryan Haasken [ 30/Apr/14 ]

Here is the port to b2_5: http://review.whamcloud.com/#/c/10178/

Comment by Ryan Haasken [ 12/May/14 ]

John, the patch for b2_5 looks like it's ready to land.

Comment by Ryan Haasken [ 27/May/14 ]

Bobi Jam's version of the b2_5 patch has landed:

http://review.whamcloud.com/#/c/10363/

I will abandon my b2_5 patch here:

http://review.whamcloud.com/#/c/10178/

Generated at Sat Feb 10 01:34:26 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.