[LU-3517] ll_lookup_it() checks for O_CREAT in it_create_mode Created: 26/Jun/13  Updated: 26/Jul/13  Resolved: 26/Jul/13

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.5.0
Fix Version/s: Lustre 2.5.0

Type: Bug Priority: Critical
Reporter: John Hammond Assignee: John Hammond
Resolution: Fixed Votes: 0
Labels: llite

Severity: 3
Rank (Obsolete): 8850

 Description   

ll_lookup_it() checks for O_CREAT in it_create_mode which is nonsensical, as it_flags is used for open flags (O_RDWR, O_CREAT, ...), while it_create_mode is used for file mode bits (S_IFREG, S_IRUSR, ...):

        if (it->it_op & IT_CREAT ||
            (it->it_op & IT_OPEN && it->it_create_mode & O_CREAT))
		opc = LUSTRE_OPC_CREATE;
        else
                opc = LUSTRE_OPC_ANY;

The same is true of llu_lookup_it().

 Comments   
Comment by John Hammond [ 26/Jun/13 ]

Please see http://review.whamcloud.com/6786.

Comment by John Hammond [ 26/Jul/13 ]

Patch landed to mazaster.

Generated at Sat Feb 10 01:34:35 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.