[LU-3566] not strictly a lustre problem, but git not working?

• Status: Resolved
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: Ron Croonenberg
• Assignee: Joshua Kugler (Inactive)
• Resolution: Fixed
• Labels: no_restart
• Severity: 3

Description

I tried to go to http://git.whamcloud.com/fs/lustre-release.git on/via https://wiki.hpdd.intel.com/display/PUB/Lustre+Development

but that doesn't seem to work?

Initial code complete
Change testing is complete
Documentation changes made - N/A
Review done
Demo/review/approval from Andi
Changes are communicated
Changes are completed in production

Comments

[Robert Read (Inactive)]

I updated the wiki page to point to correct link for the Lustre repo: http://git.hpdd.intel.com/?p=fs/lustre-release.git

[Andreas Dilger]

I thought we had DNS forwarding enabled for these hosts?

Also it makes sense to make a pass through the wiki and update URLs to the new site.

[Robert Read (Inactive)]

DNS is forwarding, but I'm seeing error 403 pages when I use short pathnames like http://git.whamcloud.com/fs/lustre-relelase.git, though it does work if you use the full http://git.whamcloud.com/?p=fs/lustre-release.git. So I'm guessing this is actually an apache redirect is issue.

[Joshua Kugler (Inactive)]

This is odd. The configuration was copied from our old host at Rackspace to our new machine at Intel. If it doesn't work now, it most likely didn't work before...unless there was an additional variable we don't know about.

[Robert Read (Inactive)]

I'm pretty sure the simpler URLs worked at one point, but don't recall when I last tried to use them. It certainly possible they might have been broken before the server migration.

[Joshua Kugler (Inactive)]

I just modified my /etc/hosts to point to the old rackspace site, and confirmed that http://git.whamcloud.com/fs/lustre-release.git/ does in fact work. I'll have to find out why.

One thing that may be in play here is the fact that we were running git(web) 1.8 on Rackspace, and when we migrated to the Intel environment, on SLES11SP1, that took us back to git(web) 1.6.

[Robert Read (Inactive)]

That's interesting we had to downgrade. Hopefully we won't run into any compatibility issues with gerrit, but it should be ok since it's readonly.

[Joshua Kugler (Inactive)]

I've been doing some debugging on this, and this is what I have uncovered so far:

The recommended RewriteRule is this:

RewriteRule ^/(.*\.git/(?!/?(HEAD|info|objects|refs)).*)?$ /gitweb%{REQUEST_URI}  [L,PT]

But that generates 403 errors when trying to access URLs such as http://git-stage.hpdd.intel.com/fs/lustre-release.git as we know. If I modify the RewriteRule and take out the slash after .git like so:

RewriteRule ^/(.*\.git(?!/?(HEAD|info|objects|refs)).*)?$ /gitweb%{REQUEST_URI}  [L,PT]

The web site works fine, and I can clone via HTTP.

Not sure why the recommended configuration does not work. Does not appear to be a version thing, as git 1.8 generates the same behavior.

We do not support git clones via HTTP due to not running to post-commit hooks needed to make HTTP clones work. We might want to disable the ability to clone. It does work, but the clone one gets from an HTTP clone can be out of date.

[Joshua Kugler (Inactive)]

Testing done, and working. Config file diff here:
The additional host name would not be inserted, obviously.

--- git.whamcloud.com.conf.prod 2014-06-17 22:21:51.000000000 +0000
+++ git.whamcloud.com.conf      2014-06-17 22:47:56.000000000 +0000
@@ -1,21 +1,34 @@
+<Directory /data/srv/source>
+       Options FollowSymLinks
+       Order deny,allow
+       Allow from all
+</Directory>
+
+<Directory /usr/local/>
+       Order deny,allow
+       Allow from all
+</Directory>
+
 <VirtualHost *:80>
        ServerName      git.whamcloud.com
        ServerAlias     git
        ServerAlias git.hpdd.intel.com
+       ServerAlias git-stage.hpdd.intel.com
        DocumentRoot /data/srv/source/git.whamcloud.com
        SetEnv GITWEB_CONFIG /etc/gitweb.conf
        RewriteEngine on
        RewriteRule ^/$                                            /gitweb [PT]
-       RewriteRule ^/(.*\.git/(?!/?(HEAD|info|objects|refs)).*)?$ /gitweb%{REQUEST_URI}  [L,PT]
+       RewriteRule ^/(.*\.git(?!/?(HEAD|info|objects|refs)).*)?$ /gitweb%{REQUEST_URI}  [L,PT]
 
        # Aliases
-       ScriptAlias /gitweb             /usr/share/git-web/gitweb.cgi
-       Alias       /gitweb.css         /usr/share/git-web/gitweb.css
-       Alias       /gitweb.js          /usr/share/git-web/gitweb.js
-       Alias       /git-logo.png       /usr/share/git-web/git-logo.png
-       Alias       /git-favicon.png    /usr/share/git-web/git-favicon.png
+       ScriptAlias /gitweb             /usr/local/share/gitweb/gitweb.cgi
+       Alias       /gitweb.css         /usr/local/share/gitweb/static/gitweb.css
+       Alias       /static/gitweb.js   /usr/local/share/gitweb/static/gitweb.js
+       Alias       /git-logo.png       /usr/local/share/gitweb/static/git-logo.png
+       Alias       /git-favicon.png    /usr/local/share/gitweb/static/git-favicon.png
+       Alias       /favicon.ico        /usr/local/share/gitweb/static/git-favicon.png
+
        # Logfiles
        ErrorLog  /data/logs/httpd/git.whamcloud.com-errors.log
        CustomLog /data/logs/httpd/git.whamcloud.com.log combined
 </VirtualHost>
-

[Mike Stok (Inactive)]

I haven't played with apache for ages, it looks reasonable to me.

[Jodi Levi (Inactive)]

Approved to deploy.

[Joshua Kugler (Inactive)]

Deployed. I had forgotten that this line was also added to /etc/gitweb.conf

{{$feature

{'pathinfo'} {'default'}

= [1]}}

so that URLs would be produced properly.