[LU-3597] packet-lustre.c opcodes out of sync with lustre_idl.h Created: 16/Jul/13 Updated: 16/Oct/13 Resolved: 16/Oct/13 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.5.0 |
| Fix Version/s: | Lustre 2.5.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | Nathaniel Clark |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | ptlrpc, wireshark | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9121 | ||||||||
| Description |
|
On v2_4_52_0-2-g809d46b, the last MDS opcode in lustre_idl.h is MDS_SWAP_LAYOUTS = 61 (added by 4af3ab19), while the last MDS opcode in packet-lustre.c is MDS_GET_INFO = 53. What is the mechanism for keeping these files in sync? |
| Comments |
| Comment by Doug Oucharek (Inactive) [ 16/Jul/13 ] |
|
The original thinking in the Wireshark support was we will want to push the Lustre support plugins upstream. As such we tried to make the contrib/wireshark directory self-contained and not dependent on any Lustre files. That makes keeping the opcodes in sync an manual process (as they will be when this is upstream). However, we are not sure when we will be working to push these upstream so creating a "temporary" dependancy on lustre_idl.h would probably be ok. |
| Comment by Nathaniel Clark [ 16/Jul/13 ] |
|
It seems reasonable to have the wireshark plugin require lustre-devel (which is actually lustre-client) to build. |
| Comment by Nathaniel Clark [ 16/Jul/13 ] |
|
Using lustre_idl.h may be more complicated due to |
| Comment by Nathaniel Clark [ 16/Jul/13 ] |
|
Here's just a basic update of MDS opcodes: |
| Comment by Jodi Levi (Inactive) [ 16/Oct/13 ] |
|
Patch landed to Master. If more work is needed in this ticket please let me know and I will reopen or create new ticket for follow on work. |