[LU-3620] missing CLF_RENAME_LAST flag in CL_RENME record Created: 23/Jul/13  Updated: 23/Aug/13  Resolved: 23/Aug/13

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.4.0
Fix Version/s: Lustre 2.4.1, Lustre 2.5.0

Type: Bug Priority: Major
Reporter: Thomas LEIBOVICI - CEA (Inactive) Assignee: Zhenyu Xu
Resolution: Fixed Votes: 0
Labels: changelog

Severity: 3
Rank (Obsolete): 9319

 Description   

CLF_RENAME_LAST flag is supposed to be set in RENME changelog record
if the rename operation unlinks the target.

The following reproducer shows this is not the case in lustre 2.4.0:

  1. touch /mnt/lustre/foo
  2. touch /mnt/lustre/bar
  3. mv /mnt/lustre/foo /mnt/lustre/bar
    mv: overwrite `/mnt/lustre/bar'? yes
  4. lfs changelog lustre
    271361 01CREAT 13:28:02.446421944 2013.07.23 0x0 t=[0x300000400:0x19b51:0x0] p=[0x200000007:0x1:0x0] foo
    271363 01CREAT 13:28:04.815421715 2013.07.23 0x0 t=[0x300000400:0x19b52:0x0] p=[0x200000007:0x1:0x0] bar
    271365 08RENME 13:28:10.255420121 2013.07.23 0x0 t=[0x300000400:0x19b52:0x0] p=[0x200000007:0x1:0x0] bar s=[0x300000400:0x19b51:0x0] sp=[0x200000007:0x1:0x0] foo

RENME flag is 0x0, should be 0x01.

The flag was still correct on lustre 2.3.0:
6 08RENME 13:33:51.820025792 2013.07.23 0x1 t=[0x200000400:0x2:0x0] p=[0x61ab:0x4710a859:0x0] bar s=[0x200000400:0x1:0x0] sp=[0x61ab:0x4710a859:0x0] foo

 Comments   
Comment by Peter Jones [ 23/Jul/13 ]

Bobijam

Could you please look into this one?

Thanks

PEter

Comment by Zhenyu Xu [ 24/Jul/13 ]

patch tracking at http://review.whamcloud.com/7095

Comment by Jodi Levi (Inactive) [ 19/Aug/13 ]

Reducing from blocker as this patch landed to master. Needs to be cherry picked to b2_4.

Comment by Zhenyu Xu [ 20/Aug/13 ]

patch tracking for b2_4 at http://review.whamcloud.com/7384

Comment by Jodi Levi (Inactive) [ 23/Aug/13 ]

Patches landed to master and b2_4. Please let me know if more work is needed and I will reopen the ticket.

Generated at Sat Feb 10 01:35:29 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.