[LU-3622] mds_pack_open_flags() checks for O_NOACCESS in it_flags Created: 23/Jul/13 Updated: 04/Dec/13 Resolved: 04/Dec/13 |
|
| Status: | Closed |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.5.0 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | WC Triage |
| Resolution: | Not a Bug | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9321 |
| Description |
|
Open flags have already had the O_{{RD,WR}ONLY,RDWR} to FMODE_ {READ,WRITE,EXEC}conversion performed before they are stored in it_flags. So for mds_pack_open_flags() to check for O_NOACCESS == 3 == (FMODE_READ|FMODE_WRITE) in flags is incorrect. Currently this has no ill-effects since the only thing done in this case is to set MDS_OPEN_NORESTORE in cr_flags, and the server side handler ignores this flag. If the server begins to obey MDS_OPEN_NORESTORE then this would be bad. |
| Comments |
| Comment by Andreas Dilger [ 25/Jul/13 ] |
|
I'm not sure I understand the problem. The O_NOACCESS flag is used to be able to open a file handle without triggering underlying actions (e.g. opening a block device to configure read parameters). |
| Comment by John Hammond [ 04/Dec/13 ] |
|
I think now that I was a bit confused when I reported this. |