[LU-3694] Posix copytool cleanup

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.5.0
• Type: Technical task
• Priority: Blocker
• Reporter: Henri Doreau (Inactive)
• Assignee: Bruno Faccini (Inactive)
• Resolution: Fixed
• Labels: HSM

Description

Several minor issues have been identified during the review of the initial version of the HSM posix copytool, such as calling select() on regular files.

Issue Links

• is related to: LU-3734 Posix Copytool Application Behaviour
• is related to: LU-3971 CLONE - Posix copytool cleanup

Comments

[Peter Jones]

Henri

Will you be supplying a patch to fix these issues or could you elaborate?

Thanks

Peter

[Henri Doreau (Inactive)]

We will provide a patch.

IIRC the issues that were identified so far are:

• superfluous select() on regular files
• error messages that should be rewritten for consistency
• logging to syslog isn't possible (related to the former point and to LU-3692)

Current reviews and testing might reveal other ones.

[Bruno Faccini (Inactive)]

Hello Henri,
Sorry to ask but do you still think to provide a patch for this ticket ?
Also, did find other issues ?

[jacques-charles lafoucriere]

Yes we will rewrite all the error messages, I think I can do it in 1 or 2 weeks

[Bruno Faccini (Inactive)]

Hello J-C,

Thanks for the update, but will this also soleve the syslog logging issue ?
And alos are there others issues than the 3 ones already listed ?

[jacques-charles lafoucriere]

Patch for new err messages at http://review.whamcloud.com/7568 (faster than expected).
Still need a patch for select() bug, will do a separate one after err msg landing.

[Henri Doreau (Inactive)]

The syslog issue will be addressed by changes on liblustrapi logging facilities (see LU-3692). I'll propose a patch to get rid of select() but this one has a lower priority.

[jacques-charles lafoucriere]

This ticket must stay for 2.5 target, 7568 is a bug

[Henri Doreau (Inactive)]

Removal of select() is at http://review.whamcloud.com/#/c/7583/

[Jodi Levi (Inactive)]

This ticket needs to be a blocker for 2.5 until Change, 7568 lands, then it can be reduced.

[Jodi Levi (Inactive)]

Patch landed to Master for 2.5. New ticket LU-3971 is opened for 2.6 for remaining work. Any new patches created for this, should be linked to LU-3971.