HSM _not only_ small fixes and to do list goes here (LU-3647)

[LU-3709] Coordinator follow-on patche: code cleaning Created: 06/Aug/13  Updated: 05/Aug/20  Resolved: 17/Aug/13

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.5.0
Fix Version/s: Lustre 2.5.0

Type: Technical task Priority: Blocker
Reporter: CEA Assignee: Jinshan Xiong (Inactive)
Resolution: Fixed Votes: 0
Labels: HSM

Rank (Obsolete): 9558

 Description   

When the cdt main thread will be landing some cross-component code cleaning needs to be done:

  • replace hai_zero() by hai_first()
  • display policy in /proc must be: policy1 [policy2] policy3
  • replace use of cfs_list_XXX by kernel functions, avoid use of list_entry() in list_XXX loop
  • remove extra parenthesis in if tests in HSM mdt files
  • "find" functions like mdt_hsm_get_md_hsm() or cdt_find_request_nolock() must return NULL if not found in place of ERR_PTR(-ENOENT)
  • clean 2 err msg in mdt_hsm_cdt_agent.c
  • styles in lmv_obd.c (from LU-3365)
  • err code printed 2 times in mdt_hsm_cdt_agent.c

It will be safer to wait for sanity-hsm landing before landing these patches so maloo will validate them on the full HSM stack

I will prepare the patch



 Comments   
Comment by jacques-charles lafoucriere [ 06/Aug/13 ]

Patch are:
MDT part http://review.whamcloud.com/7254 (depends on CDT)
LMV part http://review.whamcloud.com/7252 (no dependency)

Missing is new policy display under /proc. Will do another patch for it.

Comment by jacques-charles lafoucriere [ 18/Aug/13 ]

The remaining item "display policy in /proc must be: policy1 [policy2] policy3" is in ticket LU-3756

Generated at Sat Feb 10 01:36:14 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.