[LU-3808] ptlrpcd_init() returns 0 regardless of errors Created: 21/Aug/13 Updated: 18/Sep/13 Resolved: 18/Sep/13 |
|
| Status: | Closed |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.5.0 |
| Fix Version/s: | Lustre 2.5.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | John Hammond |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | patch, ptlrpc | ||
| Severity: | 3 |
| Rank (Obsolete): | 9840 |
| Description |
|
ptlrpcd_init() returns 0 regardless of errors. |
| Comments |
| Comment by John Hammond [ 21/Aug/13 ] |
|
On this is addressed, there is the issue that ptlrpcd_addref() increments ptlrpc_users regardless of whether ptlrpcd_init() succeeded. Also what is the point of calling ptlrpcd_addref() from the obd_setup() methods? ptlrpcd_addref() and hence ptlrpcd_init() is already called from ptlrpc_init(). All of the OBD modules depend on ptlrpc anyway. Is this for liblustre? Can all of theses ptlrcpd_addref() calls just be removed? |
| Comment by Swapnil Pimpale (Inactive) [ 02/Sep/13 ] |
|
Hi, I have added a fix for the incorrect return value bug. |
| Comment by John Hammond [ 18/Sep/13 ] |
|
Patch landed to master. |