HSM _not only_ small fixes and to do list goes here (LU-3647)

[LU-3815] Fix sanity-hsm test 34: "Remove file during restore" Created: 22/Aug/13  Updated: 22/Dec/17  Resolved: 04/Nov/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.5.0
Fix Version/s: Lustre 2.9.0

Type: Technical task Priority: Critical
Reporter: Jodi Levi (Inactive) Assignee: Saurabh Tandan (Inactive)
Resolution: Fixed Votes: 0
Labels: HSM, MB

Issue Links:
Duplicate
duplicates LU-3816 Fix sanity-hsm test 35 Resolved
Related
Rank (Obsolete): 9858

 Comments   
Comment by Jinshan Xiong (Inactive) [ 23/Aug/13 ]

patch is at http://review.whamcloud.com/7431

Comment by Jodi Levi (Inactive) [ 18/Sep/13 ]

We will add tests 34, 35, and 36 to the exception list

Comment by Andreas Dilger [ 23/Sep/13 ]

The above patch is abandoned, need a different patch.

Comment by Jinshan Xiong (Inactive) [ 23/Sep/13 ]

I can create a patch in minutes - but it will be conflicted with path 7374 and 7505 which are ready to land, so i tend to think we should land them firstly and then create this one. Or we can land patch 7505 and then I'll merge fix for this issue, along with the fix of LU-3761 into patch 7374.

Comment by Jodi Levi (Inactive) [ 25/Sep/13 ]

Adding tests to exception is being handled in LU-3561 with http://review.whamcloud.com/#/c/7374/

Comment by Jinshan Xiong (Inactive) [ 26/Sep/13 ]

Test cases 34, 35, 36 are trying to delete a file being restored which will never succeed because MDT holds layout lock for restore so unlink is blocked. Therefore I will add them into exception list for now.

We may change unlink and rename so that they will acquire LOOKUP only; if this is implemented, we can reenable the test cases again.

Comment by Bruno Faccini (Inactive) [ 26/Sep/13 ]

Jodi, Jinshan, can change http://review.whamcloud.com/#/c/7374/ be tracked by this ticket (and reference it in its Commit-msg!), it makes more sense than leave it linked to LU-3561, and this will also allow to close it and be one blocker down ...

Comment by Bruno Faccini (Inactive) [ 29/Sep/13 ]

Also, could it be possible to add sub-tests 40 and 251, actually disabled by the tests environment (TEI-570, and SANITY_HSM_EXCEPT/EXCEPT usage), to the re-freshed exception list ?? This will allow to ask Tools-team to revert their changes for TEI-570 and give us hands-on to re-enable these tests when related issues become fixed.

Comment by Jinshan Xiong (Inactive) [ 30/Sep/13 ]

test_251 has already been fixed, but we have to do some more work for test_40. I will add test_40 into exception list if we don't have enough time to work out a patch.

Comment by Bruno Faccini (Inactive) [ 30/Sep/13 ]

In LU-3939 I have a patch to fix test_40, but it is dependent on TEI-570 external change. Thus to verify my patch results I actually need to add a hack to un-exclude test_40 ...

So the (John's!) idea is to leave test_40 excluded within your patch and get it land, then after some time ask Tools-team to revert their changes for TEI-570. This will allow us/me to add one Change line in my patch for LU-3939 to remove test_40 from your patch exception list with the fixed test code.

Comment by Andreas Dilger [ 02/Oct/14 ]

Test is still being skipped due to this bug. Reopen until test is running again.

Comment by Andreas Dilger [ 03/Apr/16 ]

The TEI-1041 patch to remove sanity-hsm test_40 and test_251 from the test-framework ALWAYS_EXCEPT list landed two years ago. It should be possible to re-enable those tests by removing them from the sanity-hsm ALWAYS_EXCEPT list and verify that they are now passing.

Comment by Andreas Dilger [ 09/May/16 ]

Saurabh, could you please submit a patch to remove test 34/35/36 from the ALWAYS_EXCEPT list in lustre/tests/sanity-hsm.sh and add:

Test-Parameters: testlist=sanity-hsm,sanity-hsm,sanity-hsm,sanity-hsm

to the commit message so we have some idea if these tests are now passing.

Comment by Gerrit Updater [ 10/May/16 ]

Saurabh Tandan (saurabh.tandan@intel.com) uploaded a new patch: http://review.whamcloud.com/20079
Subject: LU-3815 tests: sanity-hsm - Remove tests from Always_Except
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9628653a18001f312e2f122a07a86369341fe351

Comment by Gerrit Updater [ 08/Sep/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/20079/
Subject: LU-3815 tests: sanity-hsm - Remove tests from Always_Except
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a2009951f9e6c73d29b67c09e00e7057ff7cc973

Comment by James Nunez (Inactive) [ 04/Nov/16 ]

The patch removing the sanity-hsm tests 34, 35, and 36 has landed to the master branch, 2.8.58. Thus, this ticket can be closed.

Generated at Sat Feb 10 01:37:08 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.