[LU-389] wirecheck/wiretest cleanup for master Created: 02/Jun/11  Updated: 04/Nov/11  Resolved: 04/Nov/11

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.1.0
Fix Version/s: Lustre 2.1.0, Lustre 2.2.0

Type: Improvement Priority: Minor
Reporter: nasf (Inactive) Assignee: nasf (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Epic: cleanup
Rank (Obsolete): 4858

 Description   

There are many unused things in wirecheck/wiretest, but some useful check, like mdt_xxx are missed. It is necessary to cleanup/fix all those codes in ptlrpc/pack_generic.c, ptlrpc/ptlrpc_module.c utils/wiretest.c, utils/wirecheck.c, ptlrpc/wiretest.c, contrib/packet-lustre.c, include/lustre_net.h, ldlm/ldlm_lib.c, and so on.

 Comments   
Comment by nasf (Inactive) [ 20/Jun/11 ]

Andreas, whether we should update contrib/packet-lustre.c or not? Because it is claimed in lustre/contrib/README:

"The files in this directory are user-contributed and are not supported by Sun Microsystems, Inc. in any way."

In fact, files under contrib directory are quite old, not only "mds_body" should be cleaned, both also many others should be added. I am not whether it is worth to maintain those files under lustre/contrib.

Comment by Andreas Dilger [ 20/Jun/11 ]

If the effort is not too large, I think it would be good to update packet-lustre.c along with the other changes you are making. I always try to update this file, even if I don't use it myself.

Comment by nasf (Inactive) [ 21/Jun/11 ]

I wonder that is there any special purpose for the items order in "hf_register_info[]"? I do not think it is random order. I cannot add the missing "mdt_rec_xxx" into packet-lustre.c unless I can make clear the order.

Comment by Andreas Dilger [ 22/Jun/11 ]

I couldn't see any apparent requirement for ordering. The values are grouped together somewhat logically, but there is no explicit ordering or alignment of the values within the array that I could see.

Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » i686,client,el6,inkernel #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » i686,client,el5,ofa #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » i686,server,el6,inkernel #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » i686,client,el5,inkernel #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » x86_64,client,el5,ofa #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » i686,server,el5,ofa #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » x86_64,server,el5,ofa #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 17/Oct/11 ]

Integrated in lustre-master » i686,server,el5,inkernel #298
LU-389 update packet-lustre.c for master

Oleg Drokin : 60c6d854fbcadce00edf1543317ab229dd7ce3a9
Files :

  • lustre/contrib/packet-lustre.c
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » x86_64,client,el5,ofa #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/include/obd.h
  • lustre/obdfilter/filter.c
  • lustre/utils/wirecheck.c
  • lustre/ost/ost_handler.c
  • lustre/ptlrpc/wiretest.c
  • lustre/include/lustre/lustre_idl.h
  • lustre/ldlm/ldlm_lib.c
  • lustre/mdt/mdt_reint.c
  • lustre/mdt/mdt_open.c
  • lustre/utils/req-layout.c
  • lustre/include/lustre/lustre_user.h
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/include/lustre_net.h
  • lustre/utils/llog_reader.c
  • lustre/include/obd_class.h
  • lustre/utils/wiretest.c
  • lustre/ptlrpc/pack_generic.c
Comment by nasf (Inactive) [ 04/Nov/11 ]

The patches have been landed to Lustre-2.2

Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » i686,client,el6,inkernel #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/include/obd.h
  • lustre/include/lustre_net.h
  • lustre/ptlrpc/pack_generic.c
  • lustre/mdt/mdt_reint.c
  • lustre/ost/ost_handler.c
  • lustre/include/lustre/lustre_idl.h
  • lustre/include/lustre/lustre_user.h
  • lustre/utils/llog_reader.c
  • lustre/obdfilter/filter.c
  • lustre/utils/req-layout.c
  • lustre/utils/wiretest.c
  • lustre/ptlrpc/wiretest.c
  • lustre/utils/wirecheck.c
  • lustre/include/obd_class.h
  • lustre/ldlm/ldlm_lib.c
  • lustre/mdt/mdt_open.c
  • lustre/ptlrpc/ptlrpc_module.c
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/utils/wiretest.c
  • lustre/utils/req-layout.c
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/ptlrpc/wiretest.c
  • lustre/utils/llog_reader.c
  • lustre/include/obd_class.h
  • lustre/utils/wirecheck.c
  • lustre/mdt/mdt_reint.c
  • lustre/ptlrpc/pack_generic.c
  • lustre/include/lustre/lustre_user.h
  • lustre/mdt/mdt_open.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/obdfilter/filter.c
  • lustre/include/obd.h
  • lustre/ost/ost_handler.c
  • lustre/include/lustre_net.h
  • lustre/include/lustre/lustre_idl.h
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/mdt/mdt_reint.c
  • lustre/obdfilter/filter.c
  • lustre/include/lustre/lustre_user.h
  • lustre/ptlrpc/pack_generic.c
  • lustre/utils/wiretest.c
  • lustre/include/lustre/lustre_idl.h
  • lustre/utils/llog_reader.c
  • lustre/utils/req-layout.c
  • lustre/ptlrpc/wiretest.c
  • lustre/ost/ost_handler.c
  • lustre/utils/wirecheck.c
  • lustre/include/obd_class.h
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/mdt/mdt_open.c
  • lustre/include/lustre_net.h
  • lustre/ldlm/ldlm_lib.c
  • lustre/include/obd.h
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/ptlrpc/wiretest.c
  • lustre/utils/wirecheck.c
  • lustre/utils/wiretest.c
  • lustre/utils/llog_reader.c
  • lustre/include/obd.h
  • lustre/include/lustre/lustre_user.h
  • lustre/ldlm/ldlm_lib.c
  • lustre/utils/req-layout.c
  • lustre/mdt/mdt_open.c
  • lustre/include/obd_class.h
  • lustre/ptlrpc/pack_generic.c
  • lustre/ost/ost_handler.c
  • lustre/include/lustre/lustre_idl.h
  • lustre/include/lustre_net.h
  • lustre/mdt/mdt_reint.c
  • lustre/obdfilter/filter.c
  • lustre/ptlrpc/ptlrpc_module.c
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/utils/wirecheck.c
  • lustre/obdfilter/filter.c
  • lustre/ptlrpc/pack_generic.c
  • lustre/include/lustre_net.h
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/include/obd_class.h
  • lustre/ldlm/ldlm_lib.c
  • lustre/mdt/mdt_reint.c
  • lustre/utils/llog_reader.c
  • lustre/mdt/mdt_open.c
  • lustre/utils/wiretest.c
  • lustre/include/obd.h
  • lustre/ost/ost_handler.c
  • lustre/include/lustre/lustre_user.h
  • lustre/utils/req-layout.c
  • lustre/ptlrpc/wiretest.c
  • lustre/include/lustre/lustre_idl.h
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/utils/wirecheck.c
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/mdt/mdt_open.c
  • lustre/include/lustre/lustre_user.h
  • lustre/include/lustre/lustre_idl.h
  • lustre/include/lustre_net.h
  • lustre/ptlrpc/pack_generic.c
  • lustre/ptlrpc/wiretest.c
  • lustre/include/obd.h
  • lustre/ost/ost_handler.c
  • lustre/utils/req-layout.c
  • lustre/obdfilter/filter.c
  • lustre/utils/llog_reader.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/mdt/mdt_reint.c
  • lustre/utils/wiretest.c
  • lustre/include/obd_class.h
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/ptlrpc/pack_generic.c
  • lustre/utils/wiretest.c
  • lustre/include/obd_class.h
  • lustre/include/lustre_net.h
  • lustre/ptlrpc/wiretest.c
  • lustre/ost/ost_handler.c
  • lustre/include/lustre/lustre_user.h
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/obdfilter/filter.c
  • lustre/utils/llog_reader.c
  • lustre/include/obd.h
  • lustre/ldlm/ldlm_lib.c
  • lustre/include/lustre/lustre_idl.h
  • lustre/utils/req-layout.c
  • lustre/utils/wirecheck.c
  • lustre/mdt/mdt_open.c
  • lustre/mdt/mdt_reint.c
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » x86_64,server,el5,ofa #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/include/lustre/lustre_user.h
  • lustre/mdt/mdt_open.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/ost/ost_handler.c
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/ptlrpc/wiretest.c
  • lustre/utils/wiretest.c
  • lustre/utils/req-layout.c
  • lustre/include/obd.h
  • lustre/utils/wirecheck.c
  • lustre/obdfilter/filter.c
  • lustre/include/lustre/lustre_idl.h
  • lustre/include/obd_class.h
  • lustre/include/lustre_net.h
  • lustre/ptlrpc/pack_generic.c
  • lustre/utils/llog_reader.c
  • lustre/mdt/mdt_reint.c
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » i686,server,el5,inkernel #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/utils/llog_reader.c
  • lustre/ptlrpc/pack_generic.c
  • lustre/include/lustre/lustre_idl.h
  • lustre/utils/req-layout.c
  • lustre/include/obd_class.h
  • lustre/mdt/mdt_reint.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/include/lustre/lustre_user.h
  • lustre/include/obd.h
  • lustre/utils/wiretest.c
  • lustre/utils/wirecheck.c
  • lustre/mdt/mdt_open.c
  • lustre/obdfilter/filter.c
  • lustre/ost/ost_handler.c
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/ptlrpc/wiretest.c
  • lustre/include/lustre_net.h
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » i686,server,el6,inkernel #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/utils/llog_reader.c
  • lustre/utils/wiretest.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/mdt/mdt_reint.c
  • lustre/utils/req-layout.c
  • lustre/mdt/mdt_open.c
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/ptlrpc/wiretest.c
  • lustre/include/obd.h
  • lustre/include/obd_class.h
  • lustre/ost/ost_handler.c
  • lustre/utils/wirecheck.c
  • lustre/include/lustre/lustre_user.h
  • lustre/ptlrpc/pack_generic.c
  • lustre/obdfilter/filter.c
  • lustre/include/lustre/lustre_idl.h
  • lustre/include/lustre_net.h
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » i686,server,el5,ofa #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/mdt/mdt_reint.c
  • lustre/ptlrpc/pack_generic.c
  • lustre/ptlrpc/wiretest.c
  • lustre/include/lustre/lustre_idl.h
  • lustre/include/lustre/lustre_user.h
  • lustre/include/obd.h
  • lustre/include/lustre_net.h
  • lustre/mdt/mdt_open.c
  • lustre/utils/wiretest.c
  • lustre/utils/wirecheck.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/ost/ost_handler.c
  • lustre/obdfilter/filter.c
  • lustre/utils/req-layout.c
  • lustre/utils/llog_reader.c
  • lustre/include/obd_class.h
  • lustre/ptlrpc/ptlrpc_module.c
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » i686,client,el5,inkernel #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/obdfilter/filter.c
  • lustre/utils/llog_reader.c
  • lustre/mdt/mdt_open.c
  • lustre/mdt/mdt_reint.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/include/lustre_net.h
  • lustre/ost/ost_handler.c
  • lustre/include/lustre/lustre_user.h
  • lustre/ptlrpc/pack_generic.c
  • lustre/utils/req-layout.c
  • lustre/utils/wiretest.c
  • lustre/ptlrpc/wiretest.c
  • lustre/utils/wirecheck.c
  • lustre/include/obd_class.h
  • lustre/include/obd.h
  • lustre/include/lustre/lustre_idl.h
  • lustre/ptlrpc/ptlrpc_module.c
Comment by Build Master (Inactive) [ 04/Nov/11 ]

Integrated in lustre-master » i686,client,el5,ofa #340
LU-389 update wirecheck for master (Revision cc6ce9c787a9a119ac2df673d68114908c34b0a8)

Result = SUCCESS
Oleg Drokin : cc6ce9c787a9a119ac2df673d68114908c34b0a8
Files :

  • lustre/include/lustre/lustre_idl.h
  • lustre/mdt/mdt_reint.c
  • lustre/include/lustre/lustre_user.h
  • lustre/include/lustre_net.h
  • lustre/include/obd.h
  • lustre/ptlrpc/wiretest.c
  • lustre/mdt/mdt_open.c
  • lustre/ost/ost_handler.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/include/obd_class.h
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/utils/req-layout.c
  • lustre/obdfilter/filter.c
  • lustre/utils/wiretest.c
  • lustre/utils/llog_reader.c
  • lustre/ptlrpc/pack_generic.c
  • lustre/utils/wirecheck.c
Generated at Sat Feb 10 01:06:32 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.