[LU-4067] bad error return from osd_object_create() Created: 05/Oct/13 Updated: 31/Dec/13 Resolved: 31/Dec/13 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.5.0 |
| Fix Version/s: | Lustre 2.6.0, Lustre 2.5.1 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | John Hammond |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | coccinelle, zfs | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 10901 | ||||||||
| Description |
|
An error path in the ZFS osd_object_create() applies PTR_ERR() to the valid thandle pointer: db = osd_create_type_f(dof->dof_type)(env, osd, attr, zapid, oh);
if (IS_ERR(db))
GOTO(out, rc = PTR_ERR(th));
Surely PTR_ERR(db) should be used instead. This was found using one of the coccinelle example scripts. Also 'Quota' is misspelled in a comment. |
| Comments |
| Comment by John Hammond [ 08/Oct/13 ] |
|
Please see http://review.whamcloud.com/7887. |
| Comment by John Hammond [ 28/Oct/13 ] |
|
Patch landed to master. |
| Comment by Jessica A. Popp (Inactive) [ 21/Nov/13 ] |
|
Can this bug be closed? |