[LU-42] e2fsprogs doesn't build with lustre patches applied and without --with-lustre configure switch

• Status: Resolved
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: Brian Murrell (Inactive)
• Assignee: Brian Murrell (Inactive)
• Resolution: Fixed
• Severity: 3

Description

With the lustre/lfsck patches applied to upstream 1.41.12 you cannot configure and build e2fsprogs without the --with-lustre switch:

$ quilt push -a
...
$ ./configure
...
$ make -j8
...
making all in e2fsck
make[2]: Entering directory `/home/brian/e2fsprogs-from-git.whamcloud.com/e2fsck'
COMPILE_ET prof_err.et
CC gen_crc32table
CC dict.c
COMPILE_ET prof_err.et
CC pass6.c
CC lfsck_common.c
CC lfsck.c
SUBST e2fsck.8
../util/subst -t -f ../util/subst.conf ./lfsck.8.in lfsck.8
SUBST e2fsck.conf.5
CC unix.c
CC e2fsck.c
CC super.c
In file included from lfsck_common.c:28:
lfsck.h:10: fatal error: lustre/liblustreapi.h: No such file or directory
compilation terminated.
In file included from pass6.c:30:
lfsck.h:10: fatal error: lustre/liblustreapi.h: No such file or directory
compilation terminated.
make[2]: *** [lfsck_common.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [pass6.o] Error 1
In file included from unix.c:62:
lfsck.h:10: fatal error: lustre/liblustreapi.h: No such file or directory
compilation terminated.
make[2]: *** [unix.o] Error 1
In file included from lfsck.c:78:
lfsck.h:10: fatal error: lustre/liblustreapi.h: No such file or directory
compilation terminated.
make[2]: *** [lfsck.o] Error 1
make[2]: Leaving directory `/home/brian/e2fsprogs-from-git.whamcloud.com/e2fsck'
make[1]: *** [all-progs-recursive] Error 1
make[1]: Leaving directory `/home/brian/e2fsprogs-from-git.whamcloud.com'
make: *** [all] Error 2

Comments

[Andreas Dilger]

This issue is being fixed as part of LU-133. There are two separate problems exposed here.

The first one is that --enable-lfsck and --without-lustre are incompatible configure options. Since the fixes in LU-135 congigure will return an error if --enable-lfsck is used (the default once the lfsck patch is applied) but no liblustreapi.h file can be found.

There is a second problem of --disable-lfsck causing the build to also fail, which only appeared as part of LU-135, and was caused by e2fsck_lfsck_find_ea() no longer having a "compat" macro for the !ENABLE_LFSCK case after it was renamed from e2fsck_lfsck_found_ea(), and a new function e2fsck_lfsck_save_ea() not having a "compat" macro at all. Both are fixed in the LU-133 commit.

[Andreas Dilger]

Fixed via LU-133. See previous comment for details.