[LU-4488] build with --enable-invariants is broken Created: 15/Jan/14  Updated: 22/Feb/14  Resolved: 22/Feb/14

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.6.0
Fix Version/s: Lustre 2.6.0

Type: Bug Priority: Critical
Reporter: Dmitry Eremin (Inactive) Assignee: Dmitry Eremin (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 12287

 Description   

Making all in .
cc1: warnings being treated as errors
/home/rpmbuild/BUILD/lustre-2.5.54/lustre/osc/osc_lock.c: In function 'osc_lock_has_pages':
/home/rpmbuild/BUILD/lustre-2.5.54/lustre/osc/osc_lock.c:1487: error: passing argument 2 of 'osc_page_gang_lookup' from incompatible pointer type
/home/rpmbuild/BUILD/lustre-2.5.54/lustre/osc/osc_cl_internal.h:691: note: expected 'struct cl_io *' but argument is of type 'struct osc_object *'
/home/rpmbuild/BUILD/lustre-2.5.54/lustre/osc/osc_lock.c:1487: error: passing argument 3 of 'osc_page_gang_lookup' from incompatible pointer type
/home/rpmbuild/BUILD/lustre-2.5.54/lustre/osc/osc_cl_internal.h:691: note: expected 'struct osc_object *' but argument is of type 'struct cl_io *'
make[7]: *** [/home/rpmbuild/BUILD/lustre-2.5.54/lustre/osc/osc_lock.o] Error 1
make[6]: *** [/home/rpmbuild/BUILD/lustre-2.5.54/lustre/osc] Error 2
make[6]: *** Waiting for unfinished jobs....
make[5]: *** [/home/rpmbuild/BUILD/lustre-2.5.54/lustre] Error 2
make[4]: *** [_module_/home/rpmbuild/BUILD/lustre-2.5.54] Error 2
make[3]: *** [modules] Error 2
make[2]: *** [all-recursive] Error 1
make[1]: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.KuGV57 (%build)

 Comments   
Comment by Dmitry Eremin (Inactive) [ 15/Jan/14 ]

It is broken since the following commit:

commit 0a259bd7dbac76d75b89a389bc317720153aa452
Author: Jinshan Xiong <jinshan.xiong@intel.com>
Date:   Mon Sep 30 15:00:38 2013 -0700

    LU-3321 clio: collapse layer of cl_page
    
    Move radix tree to osc layer to for performance improvement.
    
    Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com>
    Change-Id: I93e3cb8352f7be41c23465b12945874316aa1809
    Reviewed-on: http://review.whamcloud.com/7892
    Tested-by: Jenkins
    Tested-by: Maloo <hpdd-maloo@intel.com>
    Reviewed-by: Lai Siyao <lai.siyao@intel.com>
    Reviewed-by: Bobi Jam <bobijam@gmail.com>
    Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Comment by Dmitry Eremin (Inactive) [ 15/Jan/14 ]

Proposed fix is http://review.whamcloud.com/#/c/8853/

Comment by Dmitry Eremin (Inactive) [ 22/Feb/14 ]

Patch landed to master.

Generated at Sat Feb 10 01:43:10 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.