[LU-4516] missing leXX_to_cpu() on some accesses to struct lu_dirpage and struct lu_dirent members Created: 20/Jan/14 Updated: 07/Mar/14 Resolved: 07/Mar/14 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.6.0 |
| Fix Version/s: | Lustre 2.6.0 |
| Type: | Bug | Priority: | Blocker |
| Reporter: | John Hammond | Assignee: | Di Wang |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | MB, endianness, mdc | ||
| Severity: | 3 |
| Rank (Obsolete): | 12355 |
| Description |
|
Looking at the source (v2_5_54_0-32-g5aa4ccc) I see several accesses to the members of lu_dirpage and lu_dirent that do not use leXX_to_cpu(). Here are a few: d lustre/mdc/mdc_request.c mdc_read_entry 1676 if (dp->ldp_hash_end == MDS_DIR_END_OFF) {
e lustre/mdc/mdc_request.c mdc_read_entry 1681 op_data->op_hash_offset = dp->ldp_hash_end;
f lustre/mdc/mdc_request.c mdc_read_entry 1762 if (dp->ldp_hash_end < op_data->op_hash_offset)
9 lustre/mdc/mdc_request.c mdc_read_entry 1667 if (ent->lde_hash > op_data->op_hash_offset)
a lustre/mdc/mdc_request.c mdc_read_entry 1767 if (ent->lde_hash >= op_data->op_hash_offset)
I didn't try to find all of them. |
| Comments |
| Comment by Jodi Levi (Inactive) [ 23/Jan/14 ] |
|
Di, |
| Comment by Di Wang [ 30/Jan/14 ] |
|
Ok, I will cook a patch. |
| Comment by Di Wang [ 20/Feb/14 ] |
| Comment by Jodi Levi (Inactive) [ 07/Mar/14 ] |
|
Patch has landed to Master. Please reopen if more work is needed. |