[LU-454] osc_io_submit_page() set OBD_BRW_NOQUOTA incorrectly

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.0.0
• Type: Bug
• Priority: Minor
• Reporter: Niu Yawei (Inactive)
• Assignee: Niu Yawei (Inactive)
• Resolution: Won't Fix
• Severity: 3

Description

Actually, the ignore quota flag has already been set before the osc page entering the cache, and the caller of osc_io_submit_page() is usually not the original write submiting process, so setting ignore quota flag in osc_io_submit_page() could wrongly overwrite the original flag, I think we can just simply remove the following piece of code in osc_io_submit_page():

if (!client_is_remote(osc_export(cl2osc(opg->ops_cl.cpl_obj))) &&
cfs_capable(CFS_CAP_SYS_RESOURCE))

{ oap->oap_brw_flags |= OBD_BRW_NOQUOTA; oap->oap_cmd |= OBD_BRW_NOQUOTA; }

Comments

[Niu Yawei (Inactive)]

As discussed with Jay, there is a check for 'if cfs_list_empty(&oap->oap_pending_item)' before calling osc_io_submit_page() in osc_io_submit(), so we guarantee that the osc_io_submit_page() will not be called on cached pages, then the setting ignore quota flag in osc_io_submit_page() is just a redundant operation, and it'll not cause any other trouble.

Mark it as won't fix.