[LU-462] lut_client_alloc/free() shouldn't be called for self_export Created: 25/Jun/11  Updated: 08/Oct/12  Resolved: 08/Oct/12

Status: Closed
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.2.0

Type: Bug Priority: Minor
Reporter: Mikhail Pershin Assignee: Mikhail Pershin
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 4862

 Description   

There are two bad effects with obd_self_export passing to lut_client_alloc/free. First, it is just not needed to allocate client data for it, second, this can cause assertion in lut_client_free() if lut_init() wasn't called due to failed mdt_init0().

Fix could be just check for exp == exp->exp_obd->obd_self_export in mdt/obdfilter. Alternatively that can be done inside lut_client_alloc/free but I like to keep them generic

 Comments   
Comment by Andreas Dilger [ 06/Jul/11 ]

It isn't clear whether this is a problem that you hit during testing, or just from code inspection? Is there a corresponding ORI- issue that this is based on?

Comment by Mikhail Pershin [ 07/Jul/11 ]

Wang Di hit it during his DNE work, the problem is self_export is created along with obd and before lu_target therefore error path tries to destroy self_export with hitting assertion in lut_client_free(): LASSERT(lut); There is not ORI issue, I filled only this bug.

Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/mdt/mdt_handler.c
  • lustre/mgs/mgs_handler.c
  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » i686,server,el6,inkernel #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/mdt/mdt_handler.c
  • lustre/mgs/mgs_handler.c
  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/mgs/mgs_handler.c
  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » i686,server,el5,inkernel #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/obdfilter/filter.c
  • lustre/mgs/mgs_handler.c
  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/mgs/mgs_handler.c
  • lustre/mdt/mdt_handler.c
  • lustre/obdfilter/filter.c
  • lustre/ptlrpc/target.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/obdfilter/filter.c
  • lustre/mgs/mgs_handler.c
  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » x86_64,client,el5,ofa #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
  • lustre/mgs/mgs_handler.c
  • lustre/obdfilter/filter.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/obdfilter/filter.c
  • lustre/ptlrpc/target.c
  • lustre/mdt/mdt_handler.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » x86_64,server,el5,ofa #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/mgs/mgs_handler.c
  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » i686,client,el6,inkernel #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » i686,client,el5,ofa #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » i686,client,el5,inkernel #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 19/Oct/11 ]

Integrated in lustre-master » i686,server,el5,ofa #302
LU-462 Don't alloc/free client data for self export

Oleg Drokin : 273e40aa6a61423ddf9c9cea4c1b9d092f0d3116
Files :

  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
  • lustre/mgs/mgs_handler.c
Comment by Vitaly Fertman [ 26/Oct/11 ]

this leads to memleaks:

  1. REFORMAT=--reformat ONLY=900 sh lustre/tests/sanity.sh
    ...

LustreError: 31993:0:(class_obd.c:603:cleanup_obdclass()) obd_memory max: 21357492, leaked: 384
LustreError: 32010:0:(module.c:458:exit_libcfs_module()) Portals memory leaked: 5120 bytes

Comment by Mikhail Pershin [ 26/Oct/11 ]

yes, there is preliminary patch already to fix that, it removes memleaks though it is not yet proven as correct:
http://review.whamcloud.com/#change,1574

Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » i686,client,el6,inkernel #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/mgs/mgs_handler.c
  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/obdfilter/filter.c
  • lustre/ptlrpc/target.c
  • lustre/mdt/mdt_handler.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » x86_64,client,el5,ofa #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/mgs/mgs_handler.c
  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/mgs/mgs_handler.c
  • lustre/mdt/mdt_handler.c
  • lustre/obdfilter/filter.c
  • lustre/ptlrpc/target.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
  • lustre/mgs/mgs_handler.c
  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/ptlrpc/target.c
  • lustre/mdt/mdt_handler.c
  • lustre/obdfilter/filter.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/obdfilter/filter.c
  • lustre/ptlrpc/target.c
  • lustre/mdt/mdt_handler.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » i686,server,el6,inkernel #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/mgs/mgs_handler.c
  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » x86_64,server,el5,ofa #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/ptlrpc/target.c
  • lustre/mdt/mdt_handler.c
  • lustre/obdfilter/filter.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » i686,server,el5,inkernel #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » i686,server,el5,ofa #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » i686,client,el5,inkernel #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/obdfilter/filter.c
  • lustre/mgs/mgs_handler.c
  • lustre/ptlrpc/target.c
  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 31/Oct/11 ]

Integrated in lustre-master » i686,client,el5,ofa #327
Revert "LU-462 Don't alloc/free client data for self export" (Revision dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb)

Result = SUCCESS
Oleg Drokin : dbc82b14c7aae75d3ae7618c8a8f5cc5a561eabb
Files :

  • lustre/obdfilter/filter.c
  • lustre/ptlrpc/target.c
  • lustre/mdt/mdt_handler.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/mdt/mdt_handler.c
  • lustre/obdfilter/filter.c
  • lustre/ptlrpc/target.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/ptlrpc/target.c
  • lustre/mdt/mdt_handler.c
  • lustre/mgs/mgs_handler.c
  • lustre/obdfilter/filter.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » i686,client,el6,inkernel #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/mgs/mgs_handler.c
  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » x86_64,client,el5,ofa #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
  • lustre/mgs/mgs_handler.c
  • lustre/obdfilter/filter.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/mgs/mgs_handler.c
  • lustre/ptlrpc/target.c
  • lustre/mdt/mdt_handler.c
  • lustre/obdfilter/filter.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/ptlrpc/target.c
  • lustre/mgs/mgs_handler.c
  • lustre/mdt/mdt_handler.c
  • lustre/obdfilter/filter.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/ptlrpc/target.c
  • lustre/mdt/mdt_handler.c
  • lustre/obdfilter/filter.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » x86_64,server,el5,ofa #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
  • lustre/mgs/mgs_handler.c
  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » i686,server,el6,inkernel #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
  • lustre/mgs/mgs_handler.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » i686,server,el5,inkernel #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
  • lustre/mgs/mgs_handler.c
  • lustre/ptlrpc/target.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » i686,server,el5,ofa #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/ptlrpc/target.c
  • lustre/mgs/mgs_handler.c
  • lustre/obdfilter/filter.c
  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » i686,client,el5,inkernel #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/obdfilter/filter.c
  • lustre/ptlrpc/target.c
  • lustre/mgs/mgs_handler.c
  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 03/Nov/11 ]

Integrated in lustre-master » i686,client,el5,ofa #333
LU-462 Don't alloc/free client data for self export (Revision ed372d14c79c1873bfa57b9cd01eec2307dc3765)

Result = SUCCESS
Oleg Drokin : ed372d14c79c1873bfa57b9cd01eec2307dc3765
Files :

  • lustre/mgs/mgs_handler.c
  • lustre/mdt/mdt_handler.c
  • lustre/ptlrpc/target.c
  • lustre/obdfilter/filter.c
Comment by Mikhail Pershin [ 08/Oct/12 ]

landed

Generated at Sat Feb 10 01:07:16 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.