[LU-4655] configure --disable-libcfs-trace is broken

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.6.0
• Fix Version/s: Lustre 2.6.0
• Type: Bug
• Priority: Minor
• Reporter: John Hammond
• Assignee: John Hammond
• Resolution: Fixed
• Labels: build, libcfs
• Severity: 3

Description

Passing --disable-libcfs-trace to configure defines CDEBUG_ENTRY_EXIT as 0. In libcfs_debug.h we test if CDEBUG_ENTRY_EXIT is defined and enable trace accordingly.

AC_MSG_CHECKING([whether to enable ENTRY/EXIT])
AC_ARG_ENABLE([libcfs_trace],
        AC_HELP_STRING([--disable-libcfs-trace],
        	        [disable libcfs ENTRY/EXIT]),
	[],[enable_libcfs_trace='yes'])
AC_MSG_RESULT([$enable_libcfs_trace])
if test x$enable_libcfs_trace = xyes; then
   AC_DEFINE(CDEBUG_ENTRY_EXIT, 1, [enable libcfs ENTRY/EXIT])
else
   AC_DEFINE(CDEBUG_ENTRY_EXIT, 0, [disable libcfs ENTRY/EXIT])
fi

Since GOTO() uses D_TRACE it should also be controlled by this option.

Comments

[John Hammond]

Please see http://review.whamcloud.com/#/c/9517/.

[John Hammond]

Patch landed to master.