[LU-4699] bad ERR_PTR() use Created: 03/Mar/14 Updated: 12/Aug/14 Resolved: 03/May/14 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.6.0 |
| Fix Version/s: | Lustre 2.6.0, Lustre 2.5.3 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | John Hammond |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | ERR_PTR, RoDC | ||
| Severity: | 3 |
| Rank (Obsolete): | 12922 |
| Description |
/root/lustre-release/lustre/lmv/lmv_obd.c:1796:10: warning: ERR_PTR cast
RETURN((void *)oinfo);
~~~~~~~^~~~~~~~~~~~~~
/root/lustre-release/lustre/lod/lproc_lod.c:321:8: warning: ERR_PTR passed
rc = next->ld_ops->ldo_process_config(NULL, next, lcfg);
^ ~~~~
/root/lustre-release/lustre/lod/lproc_lod.c:326:2: warning: ERR_PTR passed
lustre_cfg_free(lcfg);
^ ~~~~
/root/lustre-release/lustre/lov/lov_io.c:203:26: warning: ERR_PTR passed
result = cl_io_sub_init(sub->sub_env, sub_io,
^ ~~~~~~~~~~~~
/root/lustre-release/lustre/lov/lov_io.c:731:9: warning: ERR_PTR dereference
sub->sub_io->u.ci_fault.ft_nob = fio->ft_nob;
^~~~~~~~~~~
/root/lustre-release/lustre/lov/lov_io.c:732:9: warning: ERR_PTR passed
lov_sub_put(sub);
^ ~~~
/root/lustre-release/lustre/lov/lov_lock.c:91:34: warning: ERR_PTR cast
subenv = (void*)sub;
^~~~~~~~~~
/root/lustre-release/lustre/lov/lov_lock.c:173:14: warning: ERR_PTR cast
sublock = (void *)subenv;
^~~~~~~~~~~~~~
/root/lustre-release/lustre/lov/lov_object.c:121:16: warning: ERR_PTR passed
RETURN(lu2cl(o));
~~~~~~~^~~~~~~~~
/root/lustre-release/lustre/lov/lov_object.c:274:14: warning: ERR_PTR passed
int sz = lov_page_slice_fixup(lov, stripe);
^ ~~~~~~
|
| Comments |
| Comment by John Hammond [ 06/Mar/14 ] |
|
http://review.whamcloud.com/9519 |
| Comment by John Hammond [ 16/Mar/14 ] |
|
And in the KEY_LAST_ID case of ofd_get_info_hdl(): /root/lustre-release/lustre/ofd/ofd_dev.c:894:3: warning: ERR_PTR passed
ofd_seq_put(tsi->tsi_env, oseq);
^ ~~~~
|
| Comment by John Hammond [ 16/Mar/14 ] |
|
Plus hundreds of unchecked returns from lustre_cfg_new(). |
| Comment by John Hammond [ 03/May/14 ] |
|
Patch landed to master. |