[LU-472] Revive replay-single 61d Created: 29/Jun/11 Updated: 09/Jan/20 Resolved: 05/Nov/19 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.1.0 |
| Fix Version/s: | Lustre 2.11.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Li Wei (Inactive) | Assignee: | Li Wei (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9723 | ||||||||
| Description |
# Skip these tests
# bug number: 17466 18857
ALWAYS_EXCEPT="61d 33a 33b $REPLAY_SINGLE_EXCEPT"
Bug 17466 was fixed in Dec, 2008. The test should be reviewed and removed from ALWAYS_EXCEPT. |
| Comments |
| Comment by Li Wei (Inactive) [ 10/Jul/11 ] |
|
Since replay-single 61d's debut in Jul, 2008, the test has been led astray from its original mission. The historical changes described below should be reverted or fixed. llog_setup_named() and llog_setup(). Originally, the fault injection simulated what might happen when the "CATALOGS" internal file was corrupted. After the changes were applied, the fault started to be injected at the first call of llog_setup_named()/llog_setup() even when lop_setup was not implemented. In other words, a fault could be injected at locations that would never fail! Another issue in these changes is that replacing llog_ctxt_destroy() with llog_ctxt_put() causes lop_cleanup to be invoked upon lop_setup failures. In general, interfaces like lop_setup should clean things up before returning an error; lop_cleanup should not be called upon lop_setup failures. test_61d(). This change looks like a result of the fictional fault injection described above. The test should stop and start the MDT rather than the MGS. |
| Comment by Li Wei (Inactive) [ 11/Jul/11 ] |
|
Johann and Andreas, any comments? |
| Comment by Johann Lombardi (Inactive) [ 11/Jul/11 ] |
|
Hi Li Wei, |
| Comment by Li Wei (Inactive) [ 19/Jul/11 ] |
|
This patch fixes the test: |
| Comment by Andreas Dilger [ 05/Nov/19 ] |
|
This was enabled in patch https://review.whamcloud.com/27404 " |