[LU-4820] extra memcpy in read path

• Status: Closed
• Project: Lustre
• Affects Version/s: Lustre 2.4.1, Lustre 2.5.0, Lustre 2.6.0, Lustre 2.4.2, Lustre 2.5.1, Lustre 2.5.2, Lustre 2.4.3
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Minor
• Reporter: Alex Zhuravlev
• Assignee: Alex Zhuravlev
• Resolution: Fixed
• Labels: llnl

Environment

ZFS

• Severity: 3

Description

osd_read_prep() in osd-zfs/ calls into dmu_read() which finds the buffers filled osd_bufs_get_read(). this is not needed and cost us extra memcpy() on all the reads.

Issue Links

• is related to: LU-5278 ZFS - many OST watchdogs with IOR

Comments

[Alex Zhuravlev]

http://review.whamcloud.com/#/c/9760/

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/9760/
Subject: LU-4820 osd: drop memcpy in zfs osd
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1249edcd71e6a44f92aba1482201b30696e85d0d

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: http://review.whamcloud.com/12990
Subject: Revert "LU-4820 osd: drop memcpy in zfs osd"
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c3ca670b48027b831c5f06d418181b97ca1e90f4

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12990/
Subject: Revert "LU-4820 osd: drop memcpy in zfs osd"
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 29288dda431cad667b3666c50c37e484fb832f67

[Gerrit Updater]

Alex Zhuravlev ([e-mail]) uploaded a new patch: http://review.whamcloud.com/12991
Subject: LU-4820 osd: drop memcpy in zfs osd
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b0651a9a3b18c6036f9a1abd92487371331fbe26

[Alex Zhuravlev]

http://review.whamcloud.com/12991

[Rick Wagner (Inactive)]

Alex,

Can you see how much work it would be to write a patch for this against b2_5? For one of our systems, we want to got with the latest 2.5 release, but I'd like to have this patch included.

Thanks,
Rick

[Gerrit Updater]

Alex Zhuravlev ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13907
Subject: LU-4820 osd: drop memcpy in zfs osd
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a65b20245b874cb20dd0b154e466547d15542730

[Alex Zhuravlev]

RIck, please have a look: http://review.whamcloud.com/13907

[Rick Wagner (Inactive)]

Thanks, Alex. Unfortunately, it looks as though there may be a dependency on other changes. The build failed looking for something in the niobuf_local structure.

In function 'osd_read_prep':
/var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/server/distro/el6/ib_stack/inkernel/BUILD/BUILD/lustre-2.5.3/lustre/osd-zfs/osd_io.c:759: error: 'struct niobuf_local' has no member named 'lnb_rc'

[Gerrit Updater]

Alex Zhuravlev ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13929
Subject: LU-4820 osd: drop memcpy in zfs osd
Project: fs/lustre-release
Branch: b2_5
Current Patch Set: 1
Commit: 7651c21a917f672e031a6d4611e563f530e4ec96

[Alex Zhuravlev]

my bad, sorry folks. please check another version.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12991/
Subject: LU-4820 osd: drop memcpy in zfs osd
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b59942cce0ed3b720ec38c3b5a25063d01b8d218

[Alex Zhuravlev]

landed to master

[Alex Zhuravlev]

any objections to close the ticket?