[LU-4849] double closedir() on error from cb_mv_init()

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.6.0
• Fix Version/s: Lustre 2.6.0
• Type: Bug
• Priority: Minor
• Reporter: John Hammond
• Assignee: Cliff White (Inactive)
• Resolution: Fixed
• Labels: lfs, patch
• Severity: 3

Description

In liblustreapi.c:cb_mv_inti() if the parent cannot be opened then we will have closed *dirp but not set it to NULL. This causes a double free when closedir() is called a second time on the way out of llapi_semantic_traverse().

        if (dirp != NULL)
                closedir(*dirp);

        if (parent == NULL) {
                dir = opendir_parent(path);
                if (dir == NULL) {
                        ret = -errno;
                        fprintf(stderr, "can not open %s ret %d\n",
				path, ret);
                        return ret;
                }
        }

Also the fprintf() call should be llapi_error(..., "cannot open '%s'").

Comments

[Swapnil Pimpale (Inactive)]

Patch: http://review.whamcloud.com/#/c/9905/

[Cliff White (Inactive)]

Thanks, the patch passed testing

[Cliff White (Inactive)]

Patch has been merged

[Gerrit Updater]

frank zago ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13441
Subject: LU-4849 user: tests for some swap layout operations
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0bfba81a653cd1068e52e471959ad79098886ca0

[Frank Zago (Inactive)]

Sorry. Wrong LU number.