[LU-4871] missing newlines at end of error messages

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.6.0
• Fix Version/s: Lustre 2.6.0, Lustre 2.7.0
• Type: Bug
• Priority: Minor
• Reporter: John Hammond
• Assignee: James Nunez (Inactive)
• Resolution: Fixed
• Labels: messages
• Severity: 3

Description

There are 70 odd CERROR/CWARN/CDEBUG... messages with missing newlines. The attached file was generated a few weeks ago.

Issue Links

• is related to: LU-5551 format at ldlm_pool.c:625:ldlm_pool_r...

Comments

[Peter Jones]

James

Could you please take care of this one?

Thanks

Peter

[John Hammond]

I also noticed two messages with double newlines:

ll_layout_refresh
osc_lock_init

--
00000008:00010000:3.0:1397487994.678070:0:5401:0:(osc_lock.c:1753:osc_lock_init()) ### lock ffff8801e4af0ed0, osc lock ffff8801e457bcc0, flags 41000

--
00000080:00010000:3.0:1397487994.678467:0:5401:0:(file.c:3975:ll_layout_refresh()) ### lustre: requeue layout lock for file [0x280000400:0x12b:0x0](ffff8802002c4b78)

[James Nunez (Inactive)]

The double newlines are a results of LDLM_DEBUG_NOLOCK being defined as:
#define LDLM_DEBUG_NOLOCK(format, a...) \
CDEBUG(D_DLMTRACE, "### " format "\n" , ##a)

So, anyone using LDLM_DEBUG_NOLOCK should not use a newline character at the end of the message. At least two uses of LDLM_DEBUG_NOLOCK used the newline, producing the double newlines printed and there are several examples of calling LDLM_DEBUG_NOLOCK without the newline character.

We have other examples of defining new routines based on CDEBUG, CL_LOCK_DEBUG for example, and we don’t add a newline character in the definition of those routines. I think we should be consistent and leave out the "\n" in the definition of LDLM_DEBUG_NOLOCK.

[James Nunez (Inactive)]

Proposed patch at http://review.whamcloud.com/#/c/10000/

[James Nunez (Inactive)]

John,

Patch http://review.whamcloud.com/#/c/10000/ landed. Should we close this ticket or do you want to generate a new list to see if there are new cases of missing newlines in the latest master?

James

[James Nunez (Inactive)]

Patch landed to master

[Cliff White (Inactive)]

With latest master, 2.6.53, I am getting buried in these messages:

iwc12 kernel: format at osc_cache.c:1473:osc_enter_cache_try doesn't end in newline

[James A Simmons]

Me too.

[James Nunez (Inactive)]

That message should be cleaned up with the LU-5551 patch at http://review.whamcloud.com/#/c/11996/3

[James Nunez (Inactive)]

Resolving ticket since patch for LU-5551, http://review.whamcloud.com/#/c/11996/3 , landed to master (pre-2.7)