In-tree documentation improvements
(LU-1892)
|
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.7.0 |
| Type: | Technical task | Priority: | Minor |
| Reporter: | Andreas Dilger | Assignee: | Richard Henwood (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Rank (Obsolete): | 13788 |
| Description |
|
Bug to track development and landing of code comments for the lustre/ofd module. |
| Comments |
| Comment by Andreas Dilger [ 30/May/14 ] |
|
ofd_fs.c: http://review.whamcloud.com/10417 |
| Comment by Johann Lombardi (Inactive) [ 04/Jun/14 ] |
|
ofd_grant.c: http://review.whamcloud.com/#/c/10586 |
| Comment by Lai Siyao [ 06/Jun/14 ] |
|
ofd_capa.c: http://review.whamcloud.com/10606 |
| Comment by Lai Siyao [ 02/Jul/14 ] |
|
lproc_osp.c: http://review.whamcloud.com/#/c/10893/ |
| Comment by Ned Bass [ 24/Jul/14 ] |
|
Please correct the following. ofd_grant.c: /home/bass6/lustre/lustre/ofd/ofd_grant.c:480: warning: argument 'niocont' of command @param is not found in the argument list of ofd_grant_check(const struct lu_env *env, struct obd_export *exp, struct obdo *oa, struct niobuf_remote *rnb, int niocount, obd_size *left) /home/bass6/lustre/lustre/ofd/ofd_grant.c:480: warning: The following parameters of ofd_grant_check(const struct lu_env *env, struct obd_export *exp, struct obdo *oa, struct niobuf_remote *rnb, int niocount, obd_size *left) are not documented: parameter 'niocount' /home/bass6/lustre/lustre/ofd/ofd_grant.c:1109: warning: The following parameters of ofd_grant_commit(const struct lu_env *env, struct obd_export *exp, int rc) are not documented: parameter 'rc' /home/bass6/lustre/lustre/ofd/ofd_grant.c:850: warning: Found unknown command `\paral' /home/bass6/lustre/lustre/ofd/ofd_grant.c:842: warning: The following parameters of ofd_grant_prepare_read(const struct lu_env *env, struct obd_export *exp, struct obdo *oa) are not documented: parameter 'oa' /home/bass6/lustre/lustre/ofd/ofd_grant.c:909: warning: argument 'niocont' of command @param is not found in the argument list of ofd_grant_prepare_write(const struct lu_env *env, struct obd_export *exp, struct obdo *oa, struct niobuf_remote *rnb, int niocount) /home/bass6/lustre/lustre/ofd/ofd_grant.c:909: warning: The following parameters of ofd_grant_prepare_write(const struct lu_env *env, struct obd_export *exp, struct obdo *oa, struct niobuf_remote *rnb, int niocount) are not documented: parameter 'niocount' ofd_fs.c /home/bass6/lustre/lustre/ofd/ofd_fs.c:49: warning: argument 'int' of command @param is not found in the argument list of ofd_precreate_batch(struct ofd_device *ofd, int batch) /home/bass6/lustre/lustre/ofd/ofd_fs.c:49: warning: The following parameters of ofd_precreate_batch(struct ofd_device *ofd, int batch) are not documented: parameter 'batch' /home/bass6/lustre/lustre/ofd/ofd_fs.c:157: warning: argument 'ofd_seq' of command @param is not found in the argument list of ofd_seq_last_oid(struct ofd_seq *oseq) /home/bass6/lustre/lustre/ofd/ofd_fs.c:157: warning: The following parameters of ofd_seq_last_oid(struct ofd_seq *oseq) are not documented: parameter 'oseq' |
| Comment by Doug Oucharek (Inactive) [ 11/Nov/14 ] |
|
Warnings addressed in patch: http://review.whamcloud.com/12665 |
| Comment by Gerrit Updater [ 04/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12665/ |